From nobody Fri Oct 17 07:38:20 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cnxWz1L5kz6Cq3m for ; Fri, 17 Oct 2025 07:38:39 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cnxWy63Bfz3jlk for ; Fri, 17 Oct 2025 07:38:38 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-b593def09e3so1126533a12.2 for ; Fri, 17 Oct 2025 00:38:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760686713; x=1761291513; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qhHgTocTP3MFWBmYA8XIGDyUKfO5iG4DtCFi9KzGL7k=; b=hDEEWXmQ0oqyUO8WabCbW7v1lgsOGmGsd5yrTjWf5l+iwGs1ap4QewpwsbQipapjOI 4woTk+9FoGgNYfj3wV96bnZaRdjiKkWEzQ5wwNgz/ufv0nNSrSPOUL3HkR7/b6MuoXIi irYAmxmIVkHY6nKO4vg0FbgIUsZesXX46vccbnNcNAjUS8IxgqymmWQpu2pikxgaVNS2 qgXNoK2x+RwitdfSkRJtYxCHhyRRpunT6iFCVmosxihbRPpUdKOA5Sq6cZpZzUfVw/6+ YQ6Z8gDQS2ca/HtKHLPiKXJ62suxBBMjvPTS4Mp6S8NXcgWlNZF7AUSfrYFXzNgOc4zY TiTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760686713; x=1761291513; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qhHgTocTP3MFWBmYA8XIGDyUKfO5iG4DtCFi9KzGL7k=; b=AXyiPygMSOl+a5DvUIQ/ebjboCh+VSE8WwAP28f3z3mFTmjFdtKneT0bQEpKSCaedr kN0kjbI/gtoYznzSNRBAdssxq52MBKw8SDYvrKupdXdD2yI4bi2IN9t8ATz1sx+vSBjz aeETH/1WWKCwuIc8H+ETokUQLhsQBZzD+iXo/e1uiGCIy9N4fskacUmVJR7AnaqIAXkn LYYybv9K3lPmrBC9CwjJiXL1yUaAl4zgbJGwxV6yPUoKlIZ+8kOHD0EuRmRji8gE++kl YjTJwH2whVTugAOMrZr5/+tpK2B1xRW2kzrRDDjlHrr6ckZExkYqUDCwbIaFSF+8KhlT CxNQ== X-Forwarded-Encrypted: i=1; AJvYcCXEV7WfvpJEvY/ml/9f8KjF5eki0r7szBkLh34BnlM8I1AH7ez+6V+OsFIos5V2z9bClHMF9dY5cu8zSmjzzBMYF+uv@freebsd.org X-Gm-Message-State: AOJu0Yyj+wkT3DJy6II+TZ6JIptIVMhrGfHFzdQJPOoNnXh/aCpgcxeb mBIDN4UVUOMod7yw1nbJMh+olmHsSck/FqMPtUE08o8NEmTX/XQBKmxV X-Gm-Gg: ASbGnctYZsFKMGX147usgrgm8kuB2aiz6Q/1WAs1V8iPocCuDB+zju29PBaOcy5nae8 tqoE6oZtK5H2SUGpJ2NcfJsuW7z2fgUGmWnTamaN0ebSm8jrH4x/b/og/ggmcJpWBsMxscv5h0+ 5XjRtp+ItijKTZC6yqJAz3itMvh4k37eeNmVk1oTQWpSIrGEKryP4peTihANAHow5CcfgCY+Sj3 lCO9Od91C1iYn2CVdzr6nhDE8IIOJDLsmdmGG3Db8NDtnzW1/iEDJt849JhdRfinO79aqv/51D7 RjvCtCBMG7r+jVUUK1Lcjr6kJElruKdpU7LrHrtUp8s8EQwCLe64NiLQNQJueB1SLwcBWg95LSf hkOLvysW2FZORXNYtEKdgABoTnZJJM2IUa2TQj63mkae3BDE97a0WrQJw5b0RF7TN8G/mA+/PHO 6GlgCJxFY+IzmgCTJL1doo1sgK+d6IXpw= X-Google-Smtp-Source: AGHT+IE8bvHu4jYGJ6YMe7ZGQbcThX3jhYlqkxQZ1IjbnRKhVFfZaI3KiaHSQ4MXwKnC4Mg+N4TdSg== X-Received: by 2002:a17:902:f542:b0:24c:b2a4:7089 with SMTP id d9443c01a7336-290ca121a5amr34547535ad.31.1760686712626; Fri, 17 Oct 2025 00:38:32 -0700 (PDT) Received: from smtpclient.apple ([185.219.141.221]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2909934a052sm54667395ad.36.2025.10.17.00.38.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Oct 2025 00:38:31 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_793319AF-3625-4CB7-987D-C49A7E0E8610"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: git: 0050289464fa - main - style(9): white space after ; and around binary operators From: "Enji Cooper (yaneurabeya)" In-Reply-To: <16835444882475995d82a23078996276@Leidinger.net> Date: Fri, 17 Oct 2025 00:38:20 -0700 Cc: Rick Macklem , "David E. O'Brien" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Message-Id: References: <202510162205.59GM5ZvD042942@gitrepo.freebsd.org> <16835444882475995d82a23078996276@Leidinger.net> To: Alexander Leidinger X-Mailer: Apple Mail (2.3826.700.81) X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_RCPT(0.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cnxWy63Bfz3jlk --Apple-Mail=_793319AF-3625-4CB7-987D-C49A7E0E8610 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 16, 2025, at 10:29=E2=80=AFPM, Alexander Leidinger = wrote: >=20 > Am 2025-10-17 01:29, schrieb Rick Macklem: >> On Thu, Oct 16, 2025 at 4:21=E2=80=AFPM Rick Macklem = wrote: >>> Please be aware of the following snippets from "man 9 style": >>> In general code can be considered "new code" when it makes up about = 50% >>> or more of the file(s) involved. This is enough to break precedents = in >>> the existing code and use the current style guidelines. >>> Stylistic changes (including whitespace changes) are hard on the = source >>> repository and are to be avoided without good reason. >>> rick >> Just to be clear, I am not asking that this commit be reverted. >> I am just suggesting that you be aware that style(9) changes to >> extant code is not, in general, encouraged, afaik unless you are >> re-writing a large portion of the code (over 50%). >=20 > Does someone remember why? We have now the possibility to exclude = commits from the VCS attribution of lines to commits (git blame), as = such, does the reason of not doing it still hold? Hi Alexander, I=E2=80=99m not sure about the percentage Rick mentioned, but I = think Mark=E2=80=99s comment about avoiding merge conflicts is a key = point (for FreeBSD as well as downstream consumers of FreeBSD. Unnecessary churn can also make reconciling changes with other = sources, e.g., NetBSD, OpenBSD, more difficult for little to no gain. Cheers, -Enji PS Has anyone tried running `clang-format -i` on these files to see how = in compliance they are with style(9) *ducks to avoid flying fruit*?= --Apple-Mail=_793319AF-3625-4CB7-987D-C49A7E0E8610 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmjx8mwACgkQGpE5DjPs NJgPNxAAiHOrHvdLe3+SPeNz2kwegiCsJAc8upxKEtXjdfxiTVePizzd1o7ofcjU dQTXGU7T+r5W2PsdWz6NZG+ZksMBcZwJUxZPeBTkPqC2hYEtx9LWJBQRsim+ccU7 btvcDl/R7k53O8nw0DDc5jxKLY48ewHaDnPJ7juUiPkqcXCQnlUj678lLJ5Xehm6 24gSvqHjYKvxDTOXq4bSjBrfW2waz7m3b4RyyngvZnHYR1s9Llce1Z5VoR8v8g/f 49a1Wl+mAJl2vrFhGZvLnDBS5DKCNujW8MklofxIZjaVqTT6S40uRFVIG/Z/8B7C CdmPZjk9Y18L43TK5lSrkZpfaMcFkfF8eOxzXIcVI3eHJ0POs+ogSwr70aG8ohxH 3fPMeRS7WOpyt+rfSGcpFkbzKSPEDw/tmAZ7fWWwb+82EJSG65BmqgnUTp4urnsU x0MHbBcysigOFRTiqADmwWLHZzJk0bH3VrxIXf3SKuJu+iTe6YptUVVGJ18qmdxQ NmuTTVKNLaljSCTiKOD7J+aEFQhFOQTA3khD5xNkpftYIGHcRHlbgHXR/24/JQN5 54xcHWtOFhdwsXtQplCcc1GiOcve42x0zJ/f1ALuf41J/uQsDqaIzYfDs2XhixjI SBP4eiJdL3rAFuOQnT7kljg+HyFlsaCbNVIqii5LAXueqZB/ouU= =kw5l -----END PGP SIGNATURE----- --Apple-Mail=_793319AF-3625-4CB7-987D-C49A7E0E8610--