From owner-svn-src-all@freebsd.org Sat Mar 30 03:15:06 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 12B99155F87D; Sat, 30 Mar 2019 03:15:06 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8B1456A5E7; Sat, 30 Mar 2019 03:15:05 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x531.google.com with SMTP id q1so2064606pgv.13; Fri, 29 Mar 2019 20:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=qeSjQHnTkQQS95Sm7vWD0otCok02oWPYQy9RUPRHrbE=; b=or017AqJcouF79F4r91+ASPp/9SvtsALCq+JwOyCOoTrnvSOK9owvfK/MqoKpvNY1V oUUXmEhYC/4VqHky/Kt8Uoy8KWFqacU2of8RF/wgixwsitHZCqGGg+2/1wQpGfC2VXeU pGQPQ6eVSXcRl+IhIBXqoatdH/ve9Bxi1fDKed1N3dOszapJ9YLxpI9zclN9y4XcmSXF xcVZoXehtwrTWf4NSr1bmlhh/FXkniQuXYTPtCbmx22GnHoI+oWaarsF8xfGB6dehBwl Jn6KsdCGtrTOyHNjVZKqw0IXrBGtxpPC0XxQMaLF7eda0cg3v/kmkjgwpvWLzn138eT6 WUYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=qeSjQHnTkQQS95Sm7vWD0otCok02oWPYQy9RUPRHrbE=; b=b2ffPC0cZJMfONVppHLcyjFvV32Ln2Mt1doKSvKXirC6cT2nh9tEUGAWbzgnBEBKR6 1pjMDEYIn0cGYsKHxGCTeVC7/KubzZ0WosEECOytVt8ePdifXRj/UUIssXHPC/s9IVRK REWt+ECMKb5gk06ak67pKij+ooxNlUExQbJRFp1X2iuBXaMzVW8WTciQKsTehhqKPBBb J4E/YNTjcEFZi4b6lNgiuNhozbJdlwOk000XlbI6q0vx4jK+zIOWb84RTh21av3ABVYV EQFyaeRitTndDD2DkuqyqQiaRNAqQhTkD5FUTW2kem/ry9CiBcUTcagj1Vh6PJKIjoSP xSbA== X-Gm-Message-State: APjAAAWfKNK0RYh4RD0VCDSUNDM9qm8OYnQ69tyiplA2PwCiHfa1jT7a QXBEPwU1djhACa4PWZKuHGr10f3cGX0= X-Google-Smtp-Source: APXvYqwOuT9McJTGZIjusnEgHSGj4c0xy3O8KowEnR3xIQc/nF+BSAdMDc/WYjr366nDwA63jwKHQA== X-Received: by 2002:a65:6144:: with SMTP id o4mr11970203pgv.247.1553915704198; Fri, 29 Mar 2019 20:15:04 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id v7sm4404732pgh.53.2019.03.29.20.15.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Mar 2019 20:15:03 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r345707 - in head: lib/clang lib/libc++ lib/libc++experimental lib/libc++fs lib/libc/tests/stdlib lib/libclang_rt lib/libcxxrt lib/libgcc_eh lib/libomp lib/ofed/libibnetdisc share/mk us... From: Enji Cooper In-Reply-To: <201903300309.x2U39DtW002526@gndrsh.dnsmgr.net> Date: Fri, 29 Mar 2019 20:15:02 -0700 Cc: Enji Cooper , src-committers , svn-src-all , svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201903300309.x2U39DtW002526@gndrsh.dnsmgr.net> To: rgrimes@freebsd.org X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: 8B1456A5E7 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.954,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Mar 2019 03:15:06 -0000 > On Mar 29, 2019, at 8:09 PM, Rodney W. Grimes = wrote: >=20 >> Author: ngie >> Date: Fri Mar 29 18:43:46 2019 >> New Revision: 345707 >> URL: https://svnweb.freebsd.org/changeset/base/345707 >>=20 >> Log: >> Revert r345706: the third time will be the charm >>=20 >> When a review is closed via Phabricator it updates the patch = attached to the >> review. I downloaded the raw patch from Phabricator, applied it, and = repeated >> my mistake from r345704 by accident mixing content from D19732 and = D19738. >=20 > Which, arguable is a feature or mis feature depending on the point > of view. I do not like it when I go to look at someone elses > committed code siting a review, as I want to actually see what > it was that was committed. You can find the pre-commit diff, > but it takes a bit of probling. The upside is you can get > both diffs from the same place and diff the diffs :-) >=20 >> For my own personal sanity, I will try not to mix reviews like this = in the >> future. >=20 > :-) Been there, almost did that too. > Pre commit last minute svn diff saved me. =E2=80=A6 This is why I=E2=80=99m doing the following from here on out: $ arc patch $ svn ci Unfortunately svn doesn=E2=80=99t support all of the niceties of =E2=80=9C= arc land=E2=80=9D. Otherwise, I would have used that. The Facebook version of =E2=80=9Carc land=E2=80=9D (before their new = non-public variation) supported verifying diffs in local repos vs = Phabricator to make sure that the diff content was consistent/correct. * Pro: it would catch issues like what I did the first time. * Con: I couldn=E2=80=99t make last minute changes (I would need to = resubmit the change and have it re-reviewed, which I argue is a good = feature). Just some food for thought. For now, arc patch/svn ci works for me. Thanks :), -Enji=