From owner-svn-src-all@freebsd.org  Sat Nov 19 10:49:47 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32CF9C4A521;
 Sat, 19 Nov 2016 10:49:47 +0000 (UTC)
 (envelope-from andrew@fubar.geek.nz)
Received: from kif.fubar.geek.nz (kif.fubar.geek.nz [178.62.119.249])
 by mx1.freebsd.org (Postfix) with ESMTP id EF00715AD;
 Sat, 19 Nov 2016 10:49:46 +0000 (UTC)
 (envelope-from andrew@fubar.geek.nz)
Received: from zapp (97e759e5.skybroadband.com [151.231.89.229])
 by kif.fubar.geek.nz (Postfix) with ESMTPSA id 8B45FD8506;
 Sat, 19 Nov 2016 10:48:47 +0000 (UTC)
Date: Sat, 19 Nov 2016 10:49:37 +0000
From: Andrew Turner <andrew@fubar.geek.nz>
To: Olivier Houchard <cognet@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r308819 - in head/sys/arm: conf ti/omap4
 ti/omap4/pandaboard ti/usb
Message-ID: <20161119104937.5e1abea8@zapp>
In-Reply-To: <201611190055.uAJ0tkN8075550@repo.freebsd.org>
References: <201611190055.uAJ0tkN8075550@repo.freebsd.org>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.29; amd64-portbld-freebsd12.0)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Nov 2016 10:49:47 -0000

On Sat, 19 Nov 2016 00:55:46 +0000 (UTC)
Olivier Houchard <cognet@FreeBSD.org> wrote:
...
> @@ -265,6 +269,16 @@ omap_ehci_probe(device_t dev)
>  	if (!ofw_bus_is_compatible(dev, "ti,ehci-omap"))
>  		return (ENXIO);
>  
> +#ifdef SOC_OMAP4
> +	/* 
> +	 * If we're running a Pandaboard, run Pandaboard-specific 
> +	 * init code.
> +	 */
> +	root = OF_finddevice("/");
> +	if (fdt_is_compatible(root, "ti,omap4-panda"))
> +		pandaboard_usb_hub_init();
> +#endif

Shouldn't this be in the attach function? It should also use
ofw_bus_node_is_compatible as I'm about to remove fdt_is_compatible.

Andrew