From nobody Mon Sep 5 20:59:14 2022 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MM1JH2fbcz4bhJy; Mon, 5 Sep 2022 21:05:35 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from sprint-2.amdmi3.ru (sprint-2.amdmi3.ru [IPv6:2a0a:2b41:94:cb5e::]) by mx1.freebsd.org (Postfix) with ESMTP id 4MM1JG31Yhz3c5x; Mon, 5 Sep 2022 21:05:34 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from amdmi3.ru (localhost [IPv6:::1]) by sprint-2.amdmi3.ru (Postfix) with SMTP id 32F10187E2A; Tue, 6 Sep 2022 00:05:27 +0300 (MSK) Received: by amdmi3.ru (nbSMTP-1.00) for uid 1000 amdmi3@amdmi3.ru; Tue, 6 Sep 2022 00:05:27 +0300 (MSK) Date: Mon, 5 Sep 2022 23:59:14 +0300 From: Dmitry Marakasov To: Dima Panov Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, portmgr@freebsd.org Subject: Re: git: e4e5c966bbc8 - main - x11/rsibreak: pet stage-qa Message-ID: References: <202209051913.285JDJ7J030927@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202209051913.285JDJ7J030927@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4MM1JG31Yhz3c5x X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of amdmi3@amdmi3.ru has no SPF policy when checking 2a0a:2b41:94:cb5e::) smtp.mailfrom=amdmi3@amdmi3.ru X-Spamd-Result: default: False [-2.00 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.997]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[amdmi3]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[amdmi3.ru]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ASN(0.00)[asn:35278, ipnet:2a0a:2b41::/32, country:RU] X-ThisMailContainsUnwantedMimeParts: N * Dima Panov (fluffy@FreeBSD.org) wrote: > commit e4e5c966bbc889b90e79f1745d523b14e6590798 > Author: Dima Panov > AuthorDate: 2022-09-05 19:05:22 +0000 > Commit: Dima Panov > CommitDate: 2022-09-05 19:07:11 +0000 > > x11/rsibreak: pet stage-qa (Replying to random commit) Note that most of these are most likely incorrect: dependencies should only list what is explicitly used by the port, while here in most cases you list transitive dependencies brought in by, for instance, some Qt components. This is erroneous, as they have in fact nothing to do with the leaf ports. A possible solution which shuts up stage-qa false positives and does not pollute ports with unrelated depends would be to bring these implicitly through the framework, as, for instance, *_USE_GNOME_IMPL does in Uses/gnome.mk > x11/rsibreak/Makefile | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/x11/rsibreak/Makefile b/x11/rsibreak/Makefile > index 71d28bbe9a20..ba4e8fcace5e 100644 > --- a/x11/rsibreak/Makefile > +++ b/x11/rsibreak/Makefile > @@ -1,5 +1,6 @@ > PORTNAME= rsibreak > DISTVERSION= 0.12.15 > +PORTREVISION= 1 > CATEGORIES= x11 kde > MASTER_SITES= KDE/stable/${PORTNAME}/${PORTVERSION:R}/ > > @@ -9,10 +10,11 @@ COMMENT= KDE RSI prevention tool > LICENSE= GPLv2+ > LICENSE_FILE= ${WRKSRC}/LICENSES/GPL-2.0-or-later.txt > > -USES= cmake compiler:c++11-lang gettext kde:5 qt:5 tar:xz > +USES= cmake compiler:c++11-lang gettext kde:5 qt:5 tar:xz xorg > USE_KDE= auth codecs config configwidgets coreaddons crash dbusaddons doctools ecm \ > iconthemes i18n idletime notifications notifyconfig \ > sonnet textwidgets xmlgui widgetsaddons windowsystem > USE_QT= core dbus gui widgets xml buildtools_build qmake_build > +USE_XORG= x11 > > .include > -- Dmitry Marakasov . amdmi3@amdmi3.ru ..: https://github.com/AMDmi3 https://amdmi3.ru/