From owner-freebsd-arch Sun Dec 23 12:27:52 2001 Delivered-To: freebsd-arch@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 0B1CA37B41B; Sun, 23 Dec 2001 12:27:49 -0800 (PST) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.6/8.11.6) with ESMTP id fBNKPml72303; Sun, 23 Dec 2001 21:25:48 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: The Anarcat Cc: arch@FreeBSD.ORG, jkh@FreeBSD.ORG Subject: Re: sysctl kern.disks shouldn't have to sort its output In-Reply-To: Your message of "Sun, 23 Dec 2001 11:43:37 EST." <20011223164336.GA34175@shall.anarcat.dyndns.org> Date: Sun, 23 Dec 2001 21:25:48 +0100 Message-ID: <72301.1009139148@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20011223164336.GA34175@shall.anarcat.dyndns.org>, The Anarcat write s: > >On Sun Dec 23, 2001 at 09:37:10AM +0100, Poul-Henning Kamp wrote: >> In message <20011222230759.GD530@shall.anarcat.dyndns.org>, The Anarcat w= >rites: >> >Anyways. If the sorting belongs to the kernel, I could do it. >> don't. > >I did. Patch attached. :) It's simple, really. It just finds a proper >place to add the disk when it is created instead of mindlessly adding it >at the HEAD of the list. > >Oh, and if this gets committed, I suggest the removal of the printfs. :) Since I think my my "MAINTAINER" status on subr_disk.c is still in good standing, consider this official notice that I object to this patch being committed. Sorting of the disks should happen in userland according to the individual applications need. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message