From owner-svn-src-all@freebsd.org Sat Dec 14 20:06:48 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B71B91D605F for ; Sat, 14 Dec 2019 20:06:48 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47Zz873dzhz3DFt for ; Sat, 14 Dec 2019 20:06:47 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x834.google.com with SMTP id k40so2055169qtk.8 for ; Sat, 14 Dec 2019 12:06:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FQ93ORcNGz2OaFUyiYHj5YS1mtix6rv/iY5IKeSb4N8=; b=xfOOkUfFwGUo5qAUImKgMX2taJ50E25ANaHTxnOPEiwDKqfHyGz7uW8IsGEwwZMrdZ koUBGrjn9oFzJGf8nZn7KxOZssoDFSJstm+UGauzMEhAce0jgcnebOS5UJ82Ltoc5Hp1 JQIWrE+4ssOIhI1ktkogWmigHh9gZuBsfA0QAgljnQIcVtP/iJjkWJCDHiGzKv2fLMqA X1cRkqPJ7JsAgWj5WaZzpv1fxVjXK0pNzxMU8ajI4/qd1XlJi7xxlLapDbdlH9+9i3mr T5lZVYHlKnnawnjK2gkEeTftrxp3qY+mUtNhJ7OABN1ZtEmkY1ABCsaTpEYqb824x/7T mW7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FQ93ORcNGz2OaFUyiYHj5YS1mtix6rv/iY5IKeSb4N8=; b=cWbPRmvvxtad9VRwuOOW/X8O3hx9q+JsBnEmOslJB06V9BFtjfSBeyUYM0f0ot+GWR qWYk/p2Fo3JWm6qDCX19BKnog1MVSjjtdDk3FlKn4tTHAFgRorOKN/RJd/DNEm/mecuQ k53H0/vC3snT9mvPyBhpgMKBaHSd8Ojz8J6FGe1M03YIpn+oqrqNtMQTKR11qb0xZCHa E+LGpzK0LRMTSXlXq/A+X8uiH2tNl4e0pnRssuhoSfC9v+3xwEA6XFyq7pn0+elXuLYe 6/qDcFAIGwG/tV0ftsP6jXl5JUELBXEVS3jJcvO23X/2tzNEZ8uXguMKDrUE+0/dFWl3 x7Ig== X-Gm-Message-State: APjAAAWyZfn12lez9UfjB2oPkJfIKq7fEgMM4+pzqnCX9PqaT/y9JIyp stCTHCsuqnT2xnS61QSXCbyKbWTC3Wyimq9Dx7I5yA== X-Google-Smtp-Source: APXvYqznCTgBoCxwqdtUYGM/JSPYVfrBaAb/RFVAMQQf29kIkvAFo1lPA64Y+8D4Wxzm54jh+/HrA2+x703htdAxRwQ= X-Received: by 2002:ac8:23af:: with SMTP id q44mr13386142qtq.175.1576354006346; Sat, 14 Dec 2019 12:06:46 -0800 (PST) MIME-Version: 1.0 References: <201912140828.xBE8SAXq027656@repo.freebsd.org> <7d4c68ec-97e9-8b29-ac70-f8167f31de37@FreeBSD.org> In-Reply-To: From: Warner Losh Date: Sat, 14 Dec 2019 13:06:33 -0700 Message-ID: Subject: Re: svn commit: r355747 - in head: . include lib/libc/stdlib lib/libxo To: "Conrad E. Meyer" Cc: Pedro Giffuni , Ryan Libby , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 47Zz873dzhz3DFt X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=xfOOkUfF; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::834) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.70 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[4.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.71)[ip: (-9.37), ipnet: 2607:f8b0::/32(-2.20), asn: 15169(-1.91), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Dec 2019 20:06:48 -0000 Thanks. Put me on the review :) Warner On Sat, Dec 14, 2019, 12:54 PM Conrad Meyer wrote: > I agree, a cdefs.h definition would be pleasant even if gcc4 isn=E2=80=99= t a > factor (and it=E2=80=99s not in about two weeks). I=E2=80=99ll go ahead a= nd do that. > > On Sat, Dec 14, 2019 at 11:28 Warner Losh wrote: > >> >> >> On Sat, Dec 14, 2019 at 12:22 PM Pedro Giffuni wrote: >> >>> >>> On 14/12/2019 13:20, Ryan Libby wrote: >>> > On Sat, Dec 14, 2019 at 12:28 AM Conrad Meyer wrote= : >>> >> Author: cem >>> >> Date: Sat Dec 14 08:28:10 2019 >>> >> New Revision: 355747 >>> >> URL: https://svnweb.freebsd.org/changeset/base/355747 >>> >> >>> >> Log: >>> >> Deprecate sranddev(3) API >>> >> >>> >> It serves no useful purpose and wasn't as popular as its equally >>> meritless >>> >> cousin, srandomdev(3). >>> >> >>> >> .. (cut unrelated code) >>> >> >>> >> Modified: head/include/stdlib.h >>> >> >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> >> --- head/include/stdlib.h Sat Dec 14 05:21:56 2019 >>> (r355746) >>> >> +++ head/include/stdlib.h Sat Dec 14 08:28:10 2019 >>> (r355747) >>> >> @@ -309,12 +309,17 @@ int rpmatch(const char *); >>> >> void setprogname(const char *); >>> >> int sradixsort(const unsigned char **, int, const unsigned cha= r >>> *, >>> >> unsigned); >>> >> -void sranddev(void); >>> >> void srandomdev(void); >>> >> long long >>> >> strtonum(const char *, long long, long long, const char **)= ; >>> >> >>> >> /* Deprecated interfaces, to be removed. */ >>> >> +static inline void >>> >> +__attribute__((__deprecated__("sranddev to be removed in FreeBSD >>> 13"))) >>> >> +sranddev(void) >>> >> +{ >>> >> +} >>> >> + >>> > This broke some gcc builds in ci. It looks like older versions of gc= c >>> > don't like having an argument to deprecated. >>> >>> FWIW, the msg argument for __deprecated__ appeared in GCC 4.5. >>> >> >> Maybe sys/cdefs.h should define a __DEPRECATED for such differences? It'= s >> not like __attribute__ is a standard thing anyway... >> >> Warner >> >