From owner-freebsd-apache@freebsd.org Fri Mar 30 15:56:22 2018 Return-Path: Delivered-To: freebsd-apache@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1FCE4F770E0 for ; Fri, 30 Mar 2018 15:56:22 +0000 (UTC) (envelope-from spil.oss@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A61C86E4BE for ; Fri, 30 Mar 2018 15:56:21 +0000 (UTC) (envelope-from spil.oss@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 6A07FF770DF; Fri, 30 Mar 2018 15:56:21 +0000 (UTC) Delivered-To: apache@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4603EF770DE for ; Fri, 30 Mar 2018 15:56:21 +0000 (UTC) (envelope-from spil.oss@gmail.com) Received: from mail-oi0-x22f.google.com (mail-oi0-x22f.google.com [IPv6:2607:f8b0:4003:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CC69B6E4BD for ; Fri, 30 Mar 2018 15:56:20 +0000 (UTC) (envelope-from spil.oss@gmail.com) Received: by mail-oi0-x22f.google.com with SMTP id 188-v6so8114499oih.8 for ; Fri, 30 Mar 2018 08:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc; bh=gnlz/VZRqd7umpQGAZVsjQ/3mEbYcdSn9yMyhLfozSE=; b=gdHVZz+0PNrgXWti1CSgjVw1u0uQAmIB479RfCjX0QFrj616tGhvt9x+YEEvGcTVAp zpnk8YFfbEbGRN5diF7TAseRF5MhIy58tncG908uA0zAMFBcWkA/oEdkzwRiHwcEm3cY sz2myQ39c9P1bwkouX+oAspIakxqWY/l6C4boAgc2befebker3zdn/oDVMY6CSWAnzHh eUh9qUYxLkw5ttVyaK9EFm6E1IUFGYcgDoVmkOHHW+SPsW0JPH6lG3irgxpKLV7LJ6tM ZaJ30Vpw08xW4hvdTfqeHB0w1/UQ/HLeXXoYki5x4YGp35cm8a2TxZNbhVm0dX94cT1+ 93aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=gnlz/VZRqd7umpQGAZVsjQ/3mEbYcdSn9yMyhLfozSE=; b=KD4KMZWNYPEDnhpBhp7UHjkoBLKnT6LL1vfVScsKcz8ZjOPR/v6sXBaHnA+MidEK5R UudtNWprLF1dN1FcDcof5O4HsIWB19ROAcTok2t5yZ23q8cdxW9queiRsPl5SOjJ+9iP Y+r5BpeS4QocuJsc0uey2DNlIVROKjortiQce7bluJKtU/2v42bsBN8+g47oKOvnOOr3 W8W0oRhmS8PomGsx3RSSYsTsbwFjKSB7JchzSIYJsGF0wBtJSTiS+pwSURtMjtVIgbgV ht6d3ET+T3WeqCgHM+jNhN57c854w7htDLRd2EDC7AJ8CyqWEFyGYueaXyqR+HlpiQIt MTjQ== X-Gm-Message-State: AElRT7EpZ4ETc+KSf3kPMSOvMqoK9KzcuUeTvE3cZWFyb21DrAdylkuK f0tO+Z/Am4hlB/GkYYL/mbGktftNxjPk7S9gBA== X-Google-Smtp-Source: AIpwx4+be5GeCX6ZZXUbGsy/UGIIOBQECcjGlZSr/1LCA7SuQzOqLiF4ShmwyQMWS0Nj14h8AhlmBVIgR7iWGcugePw= X-Received: by 10.202.117.201 with SMTP id q192mr6720843oic.319.1522425380215; Fri, 30 Mar 2018 08:56:20 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:6010:0:0:0:0:0 with HTTP; Fri, 30 Mar 2018 08:56:19 -0700 (PDT) Reply-To: spil.oss@gmail.com In-Reply-To: <1659d22a-0e5e-1dbf-5cd0-ec39d7bb3e55@gmx.de> References: <1659d22a-0e5e-1dbf-5cd0-ec39d7bb3e55@gmx.de> From: Spil Oss Date: Fri, 30 Mar 2018 17:56:19 +0200 Message-ID: Subject: Re: apache24 regression between svn r465240:465461 To: olli hauer Cc: "apache@FreeBSD.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 15:56:22 -0000 Hi Olli, Good find! I'm trying to figure out the mechanics of the `session' problem. In line we force the session module to be enabled when one of the `session_*` modules is enabled. How does it still not have that module when building? In my local tree I've added the =shared as this is a regression between existing and new building methods. As far as I know, static binaries are not preferred on FreeBSD. I've yet to see reports of people wanting it back, but that can still come. The =shared does appear in the install.html file. There's already 2 PR's for the _MODULES error we trigger from apache.mk... So we've actually duplicated the enabling of modules between apache.mk and the 2.4 port. Not pretty. As you've probably seen the 2.2 port is up for removal shortly. After we finish that I'll clean up the apache.mk file. Anyone have thoughts on having server build framework bits in Mk/Uses/apache.mk? With OptionsNG I believe the regular way of porting using Makefile moving parts to apache.mk doesn't reduce the Makefile significantly. There's an apache25-devel port in preparation, which is very similar to the 2.4 one. Cheers, Bernard. 2018-03-30 17:04 GMT+02:00 olli hauer : > Seems there is a regression in the apache24 port between svn r465240:465461 > > With the change in Makfile.options from ALL_MODULES_CATEGORIES to ALL_MODULES > it is no longer possible to build static modules since the code in Mk/Uses/apache.mk > is no longer honored. > > That's the part in apache.mk > > .for category in ${ALL_MODULES_CATEGORIES} > AVAILABLE_MODULES+= ${${category}_MODULES} > .endfor > ... > .for module in ${AVAILABLE_MODULES} > . if !empty(WITH_STATIC_MODULES:M${module}) > CONFIGURE_ARGS+= --enable-${module:tl}=static > PLIST_SUB+= MOD_${module}="@comment " > . elif !empty(APACHE_MODULES:M${module}) > CONFIGURE_ARGS+= --enable-${module:tl}=shared > PLIST_SUB+= MOD_${module}="" > . else > CONFIGURE_ARGS+= --disable-${module:tl} > PLIST_SUB+= MOD_${module}="@comment " > . endif > .endfor > > > that was replaced with this simpler part in the ports Makefile > > .for module in ${ALL_MODULES} > .if ${PORT_OPTIONS:M${module}} > CONFIGURE_ARGS+= --enable-${module:S/_/-/g:tl} > .else > CONFIGURE_ARGS+= --disable-${module:S/_/-/g:tl} > .endif > .endfor > > > That's OK, after the removal of apache22 large (server) parts of apache.mk > can be removed if we do not support static modules any longer. > > But there is another regression that will be noticed only with the original > apache24 httpd.conf the first time apache24 starts. > > httpd: Syntax error on line 143 of /usr/local/etc/apache24/httpd.conf: > Cannot load libexec/apache24/mod_session_cookie.so into server: > /usr/local/libexec/apache24/mod_session_cookie.so: Undefined symbol "ap_hook_session_save" > > > This error message has is the result of three modules (session_cookie_module, > session_crypto_module and session_dbd_module) that are enabled in httpd.conf > without enabling session_module. > > > One easy fix (dynamic modules only) could be: > > Index: apache24/Makefile > =================================================================== > --- apache24/Makefile (revision 465976) > +++ apache24/Makefile (working copy) > @@ -132,7 +132,7 @@ > > .for module in ${ALL_MODULES} > .if ${PORT_OPTIONS:M${module}} > -CONFIGURE_ARGS+= --enable-${module:S/_/-/g:tl} > +CONFIGURE_ARGS+= --enable-${module:S/_/-/g:tl}=shared > .else > CONFIGURE_ARGS+= --disable-${module:S/_/-/g:tl} > .endif > > > The difference can be shown without installing apache by comparing httpd.conf.sample in the stage dir with and without the small patch. > > I know ./configure ---help does not show the usage of --enable-$module=(shared|static|yes), but this hint can be found in acinclude.m4 and as I remember in older apache versions > > > -- > olli > _______________________________________________ > freebsd-apache@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-apache > To unsubscribe, send any mail to "freebsd-apache-unsubscribe@freebsd.org"