From owner-freebsd-current@FreeBSD.ORG Mon Feb 21 17:13:43 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B1A0516A4CE for ; Mon, 21 Feb 2005 17:13:43 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.184]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF99543D1F for ; Mon, 21 Feb 2005 17:13:40 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.207] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1D3H7Y-0000h8-00; Mon, 21 Feb 2005 18:13:20 +0100 Received: from [217.83.10.18] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1D3H7Y-0000IJ-00; Mon, 21 Feb 2005 18:13:20 +0100 From: Max Laier To: Divacky Roman Date: Mon, 21 Feb 2005 18:13:07 +0100 User-Agent: KMail/1.7.2 References: <20050221154738.GA64629@stud.fit.vutbr.cz> In-Reply-To: <20050221154738.GA64629@stud.fit.vutbr.cz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2685896.PUHvAU7OLz"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200502211813.14525.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:61c499deaeeba3ba5be80f48ecc83056 cc: current@freebsd.org Subject: Re: panic in altq X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2005 17:13:43 -0000 --nextPart2685896.PUHvAU7OLz Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 21 February 2005 16:47, Divacky Roman wrote: > I was seeing panics on boot when pf was enabled. > this patch: > > Index: altq_subr.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/ncvs/src/sys/contrib/altq/altq/altq_subr.c,v > retrieving revision 1.5 > diff -u -r1.5 altq_subr.c > --- altq_subr.c 15 Jun 2004 23:59:37 -0000 1.5 > +++ altq_subr.c 21 Feb 2005 15:44:21 -0000 > @@ -93,7 +93,7 @@ > int (*altq_input)(struct mbuf *, int) =3D NULL; > static struct mbuf *tbr_dequeue(struct ifaltq *, int); > static int tbr_timer =3D 0; /* token bucket regulator timer */ > -static struct callout tbr_callout =3D CALLOUT_INITIALIZER; > +static struct callout tbr_callout; > > #ifdef ALTQ3_CLFIER_COMPAT > static int extract_ports4(struct mbuf *, struct ip *, struct flowinfo_in > *); @@ -155,6 +155,7 @@ > void *(*classify)(void *, struct mbuf *, int); > { > IFQ_LOCK(ifq); > + callout_init(&tbr_callout, 0); > if (!ALTQ_IS_READY(ifq)) { > IFQ_UNLOCK(ifq); > return ENXIO; > > > it completly solves (it used illegaly initialized callout, dunno hows > possible it worked before) > > I hope for commiting this Done with changes. Thanks for the report. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart2685896.PUHvAU7OLz Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQBCGhaqXyyEoT62BG0RAqM5AJ0YQ5cbAW/mbXcCAuIMhBG1+FOqnwCfa3ve YBEhCu3iucblrvTWPg+chnM= =Anwi -----END PGP SIGNATURE----- --nextPart2685896.PUHvAU7OLz--