From owner-cvs-src-old@FreeBSD.ORG Mon Jun 6 23:03:51 2011 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DA08B1065672 for ; Mon, 6 Jun 2011 23:03:51 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id C953A8FC15 for ; Mon, 6 Jun 2011 23:03:51 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id p56N3paa046285 for ; Mon, 6 Jun 2011 23:03:51 GMT (envelope-from jkim@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id p56N3pK5046284 for cvs-src-old@freebsd.org; Mon, 6 Jun 2011 23:03:51 GMT (envelope-from jkim@repoman.freebsd.org) Message-Id: <201106062303.p56N3pK5046284@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to jkim@repoman.freebsd.org using -f From: Jung-uk Kim Date: Mon, 6 Jun 2011 23:03:37 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/atkbdc atkbd.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2011 23:03:51 -0000 jkim 2011-06-06 23:03:37 UTC FreeBSD src repository Modified files: sys/dev/atkbdc atkbd.c Log: SVN rev 222795 on 2011-06-06 23:03:37Z by jkim Validate INT 15h and 16h vectors more strictly. Traditionally these entry points are fixed addresses and (U)EFI CSM specification also mandated that. Unfortunately, (U)EFI CSM specification does not specifically mention this is to call service routine via interrupt vector table or to jump directly to the entry point. As a result, some CSM seems to install two routines and acts differently, depending on how it was executed, unfortunately. When INT 15h is used, it calls a function pointer (which is probably a UEFI service function). When it jumps directly to the entry point, it executes a simple and traditional INT 15h service routine. Therefore, actually there are two possible fixes, i. e., this fix or jumping directly to the fixed entry point. However, we chose this fix because a) keyboard typematic support via BIOS is becoming extremely rarer and b) we cannot support random service routine installed by a firmware or a boot loader. This should fix Lenovo X220 laptop, specifically. Reviewed by: delphij MFC after: 3 days Revision Changes Path 1.64 +2 -1 src/sys/dev/atkbdc/atkbd.c