Date: Mon, 5 Sep 2022 19:18:31 -0600 From: Adam Weinberger <adamw@freebsd.org> To: Cy Schubert <Cy.Schubert@cschubert.com>, michael.osipov@siemens.com Cc: Adam Weinberger <adamw@freebsd.org>, ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c51ce87a4ef5 - main - editors/vim-colorschemes-legacy: Add port Message-ID: <CAP7rwciAg7hB3mCV5ugNV3R1sknAV6fN4sA=13_C7GvAjkyxnw@mail.gmail.com> In-Reply-To: <20220906000036.8EE7DFB@slippy.cwsent.com> References: <202209031633.283GXB0x034705@gitrepo.freebsd.org> <20220906000036.8EE7DFB@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000679dde05e7f7fa3f Content-Type: text/plain; charset="UTF-8" On Mon, Sep 5, 2022 at 6:00 PM Cy Schubert <Cy.Schubert@cschubert.com> wrote: > In message <202209031633.283GXB0x034705@gitrepo.freebsd.org>, Adam > Weinberger w > rites: > > The branch main has been updated by adamw: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=c51ce87a4ef535f7df2c31bbf8b1cb > > d1a0f1d579 > > > > commit c51ce87a4ef535f7df2c31bbf8b1cbd1a0f1d579 > > Author: Adam Weinberger <adamw@FreeBSD.org> > > AuthorDate: 2022-09-03 16:26:48 +0000 > > Commit: Adam Weinberger <adamw@FreeBSD.org> > > CommitDate: 2022-09-03 16:26:48 +0000 > > > > editors/vim-colorschemes-legacy: Add port > > > > Upstream vim modernized their colorschemes, which is a good thing. > > However, the look of them has changed, which is jarring at best for > > users used to the original look. > > > > Upstream colorscheme development was split into a new repo, and the > > original colorschemes were imported there. This port installs those > > colorschemes. > > > > The rest of that repo are the colorschemes included in vim, so > there's > > not really any benefit to packaging anything else from it. > > > > PR: 265798 > > --- > > editors/Makefile | 1 + > > editors/vim-colorschemes-legacy/Makefile | 33 ++++++++++++ > > editors/vim-colorschemes-legacy/distinfo | 3 ++ > > editors/vim-colorschemes-legacy/files/LICENSE | 78 > +++++++++++++++++++++++++ > > ++ > > editors/vim-colorschemes-legacy/pkg-descr | 7 +++ > > editors/vim-colorschemes-legacy/pkg-plist | 17 ++++++ > > 6 files changed, 139 insertions(+) > > > > diff --git a/editors/Makefile b/editors/Makefile > > index 2a49e4899e93..2f7ab5ece415 100644 > > --- a/editors/Makefile > > +++ b/editors/Makefile > > @@ -268,6 +268,7 @@ > > SUBDIR += vigor > > SUBDIR += vile > > SUBDIR += vim > > + SUBDIR += vim-colorschemes-legacy > > SUBDIR += vscode > > SUBDIR += web-mode > > SUBDIR += with-editor > > diff --git a/editors/vim-colorschemes-legacy/Makefile > b/editors/vim-colorsche > > mes-legacy/Makefile > > new file mode 100644 > > index 000000000000..b5c1ad467ada > > --- /dev/null > > +++ b/editors/vim-colorschemes-legacy/Makefile > > @@ -0,0 +1,33 @@ > > +PORTNAME= vim-colorschemes-legacy > > +DISTVERSION= g20220816 > > +CATEGORIES= editors > > + > > +MAINTAINER= michael.osipov@siemens.com > > +COMMENT= Legacy colorschemes for Vim > > + > > +LICENSE= VIM > > +LICENSE_NAME= VIM License > > +LICENSE_FILE= ${FILESDIR}/LICENSE > > +LICENSE_PERMS= dist-mirror dist-sell pkg-mirror pkg-sell > auto-accept > > + > > +RUN_DEPENDS= vim:editors/vim > > Those who install vim-gtk* or vim-motif will notice that pkg install will > uninstall the GUI version of vim and install vim-console. > Good catch, Cy. This port doesn't actually depend on Vim and is usable by all Vim flavors (and neovim!). It does need a Vim parser of some sort to do any good, but even things like vimpager and nvimpager can use it. Michael, I'd suggest removing the RUN_DEPENDS entirely. Also, reading up on it more, this should probably go into LOCALBASE/vim/vimfiles/colors/legacy rather than in Vim's (private) runtime library path. You good with those two changes? # Adam -- Adam Weinberger adamw@adamw.org // adamw@FreeBSD.org https://www.adamw.org --000000000000679dde05e7f7fa3f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon= t-family:arial,sans-serif"><br></div></div><br><div class=3D"gmail_quote"><= div dir=3D"ltr" class=3D"gmail_attr">On Mon, Sep 5, 2022 at 6:00 PM Cy Schu= bert <<a href=3D"mailto:Cy.Schubert@cschubert.com">Cy.Schubert@cschubert= .com</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"mar= gin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1= ex">In message <<a href=3D"mailto:202209031633.283GXB0x034705@gitrepo.fr= eebsd.org" target=3D"_blank">202209031633.283GXB0x034705@gitrepo.freebsd.or= g</a>>, Adam <br> Weinberger w<br> rites:<br> > The branch main has been updated by adamw:<br> ><br> > URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3Dc51ce87a4e= f535f7df2c31bbf8b1cb" rel=3D"noreferrer" target=3D"_blank">https://cgit.Fre= eBSD.org/ports/commit/?id=3Dc51ce87a4ef535f7df2c31bbf8b1cb</a><br> > d1a0f1d579<br> ><br> > commit c51ce87a4ef535f7df2c31bbf8b1cbd1a0f1d579<br> > Author:=C2=A0 =C2=A0 =C2=A0Adam Weinberger <adamw@FreeBSD.org><b= r> > AuthorDate: 2022-09-03 16:26:48 +0000<br> > Commit:=C2=A0 =C2=A0 =C2=A0Adam Weinberger <adamw@FreeBSD.org><b= r> > CommitDate: 2022-09-03 16:26:48 +0000<br> ><br> >=C2=A0 =C2=A0 =C2=A0editors/vim-colorschemes-legacy: Add port<br> >=C2=A0 =C2=A0 =C2=A0<br> >=C2=A0 =C2=A0 =C2=A0Upstream vim modernized their colorschemes, which i= s a good thing.<br> >=C2=A0 =C2=A0 =C2=A0However, the look of them has changed, which is jar= ring at best for<br> >=C2=A0 =C2=A0 =C2=A0users used to the original look.<br> >=C2=A0 =C2=A0 =C2=A0<br> >=C2=A0 =C2=A0 =C2=A0Upstream colorscheme development was split into a n= ew repo, and the<br> >=C2=A0 =C2=A0 =C2=A0original colorschemes were imported there. This por= t installs those<br> >=C2=A0 =C2=A0 =C2=A0colorschemes.<br> >=C2=A0 =C2=A0 =C2=A0<br> >=C2=A0 =C2=A0 =C2=A0The rest of that repo are the colorschemes included= in vim, so there's<br> >=C2=A0 =C2=A0 =C2=A0not really any benefit to packaging anything else f= rom it.<br> >=C2=A0 =C2=A0 =C2=A0<br> >=C2=A0 =C2=A0 =C2=A0PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= 265798<br> > ---<br> >=C2=A0 editors/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 1 +<br> >=C2=A0 editors/vim-colorschemes-legacy/Makefile=C2=A0 =C2=A0 =C2=A0 | 3= 3 ++++++++++++<br> >=C2=A0 editors/vim-colorschemes-legacy/distinfo=C2=A0 =C2=A0 =C2=A0 |= =C2=A0 3 ++<br> >=C2=A0 editors/vim-colorschemes-legacy/files/LICENSE | 78 +++++++++++++= ++++++++++++<br> > ++<br> >=C2=A0 editors/vim-colorschemes-legacy/pkg-descr=C2=A0 =C2=A0 =C2=A0|= =C2=A0 7 +++<br> >=C2=A0 editors/vim-colorschemes-legacy/pkg-plist=C2=A0 =C2=A0 =C2=A0| 1= 7 ++++++<br> >=C2=A0 6 files changed, 139 insertions(+)<br> ><br> > diff --git a/editors/Makefile b/editors/Makefile<br> > index 2a49e4899e93..2f7ab5ece415 100644<br> > --- a/editors/Makefile<br> > +++ b/editors/Makefile<br> > @@ -268,6 +268,7 @@<br> >=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D vigor<br> >=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D vile<br> >=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D vim<br> > +=C2=A0 =C2=A0 SUBDIR +=3D vim-colorschemes-legacy<br> >=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D vscode<br> >=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D web-mode<br> >=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D with-editor<br> > diff --git a/editors/vim-colorschemes-legacy/Makefile b/editors/vim-co= lorsche<br> > mes-legacy/Makefile<br> > new file mode 100644<br> > index 000000000000..b5c1ad467ada<br> > --- /dev/null<br> > +++ b/editors/vim-colorschemes-legacy/Makefile<br> > @@ -0,0 +1,33 @@<br> > +PORTNAME=3D=C2=A0 =C2=A0 vim-colorschemes-legacy<br> > +DISTVERSION=3D g20220816<br> > +CATEGORIES=3D=C2=A0 editors<br> > +<br> > +MAINTAINER=3D=C2=A0 <a href=3D"mailto:michael.osipov@siemens.com" tar= get=3D"_blank">michael.osipov@siemens.com</a><br> > +COMMENT=3D=C2=A0 =C2=A0 =C2=A0Legacy colorschemes for Vim<br> > +<br> > +LICENSE=3D=C2=A0 =C2=A0 =C2=A0VIM<br> > +LICENSE_NAME=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 VIM License<br> > +LICENSE_FILE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ${FILESDIR}/LICENSE<br> > +LICENSE_PERMS=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0dist-mirror dist-sell pkg-= mirror pkg-sell auto-accept<br> > +<br> > +RUN_DEPENDS=3D vim:editors/vim<br> <br> Those who install vim-gtk* or vim-motif will notice that pkg install will <= br> uninstall the GUI version of vim and install vim-console.<br></blockquote><= div><br></div><div style=3D"font-family:arial,sans-serif" class=3D"gmail_de= fault">Good catch, Cy.</div><div style=3D"font-family:arial,sans-serif" cla= ss=3D"gmail_default"><br></div><div style=3D"font-family:arial,sans-serif" = class=3D"gmail_default">This port doesn't actually depend on Vim and is= usable by all Vim flavors (and neovim!). It does need a Vim parser of some= sort to do any good, but even things like vimpager and nvimpager can use i= t.</div></div><div><br></div><div><div style=3D"font-family:arial,sans-seri= f" class=3D"gmail_default">Michael, I'd suggest removing the RUN_DEPEND= S entirely. Also, reading up on it more, this should probably go into LOCAL= BASE/vim/vimfiles/colors/legacy rather than in Vim's (private) runtime = library path. You good with those two changes?</div><div style=3D"font-fami= ly:arial,sans-serif" class=3D"gmail_default"><br></div><div style=3D"font-f= amily:arial,sans-serif" class=3D"gmail_default"># Adam<br></div><br></div><= br>-- <br><div dir=3D"ltr" class=3D"gmail_signature">Adam Weinberger<br><a = href=3D"mailto:adamw@adamw.org" target=3D"_blank">adamw@adamw.org</a> // ad= amw@FreeBSD.org<br><a href=3D"https://www.adamw.org" target=3D"_blank">http= s://www.adamw.org</a></div></div> --000000000000679dde05e7f7fa3f--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwciAg7hB3mCV5ugNV3R1sknAV6fN4sA=13_C7GvAjkyxnw>