From nobody Fri May 22 15:30:57 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gMTkq55fHz6f1YM; Fri, 22 May 2026 15:30:59 +0000 (UTC) (envelope-from markj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gMTkq4JJ9z3bTh; Fri, 22 May 2026 15:30:59 +0000 (UTC) (envelope-from markj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779463859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PM3JvZtK0ZiEg9FrHFnmtsOJ5uxK8EOwIG0CIASfXl4=; b=cj6pYWRNMBcuKkTC9TsqpdGMH/2wdsFRJenebKyQioqxLo5pXIGK7aPxUWcPhh6IgKr63M AeymzsOqzmDYurTdDvTSpp1WkB8xPmCXrno/maUDo3JhIAwLJe+1TPMcfU5SvrpcQtpRuE g9OxVA8fNg2UsirtyzTVk1MfVtBg77UMgqSjQOJsvytZ5A29TEUxNZaPaKhBkUE7J3+mc4 VgXs3DfyWp66G3Nol/xARbXQ4Tt+H3OieEIOmVhIwedMRqVT/cZUePtI0q8M7PRf9COiFf HMB+hhUo57fNn1NcubWmL7lxBn83nxSy8+Rc18rzSI5hh9WNWWzTvV05vzeMRg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779463859; a=rsa-sha256; cv=none; b=AzeHFnVWRQUEOrmyaoCf/UZPpiux5RK3Gp7iAMlDSQsHwZwrJb+lGAMDDMI3uac2Jj0Dpc 7+hx+F2C6JsQuJaQ485VMgn8jUqris1AAlR692M5Gpmg41RXUFsJeV2Y8aL7oLjkQwmPYw I2agKarvOKzhHvRYhX4Dl8Qdwolv3JAXMLOZSGJqy6fFPDMQgzx8cILAZSEzoOWaw+0DKi C7b9IdM0krXNpDf0BDc8UuYDhmQLrfb59st39iKlQM7WXCtowsHyTGu/MaiIZ561bfhJOA f3xpgNGpU6/OdU2iELNEreq8rK68LVaGXsPqjlozp7aeVgWI1v8ukrKUvVSOTQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779463859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PM3JvZtK0ZiEg9FrHFnmtsOJ5uxK8EOwIG0CIASfXl4=; b=bTo42/2mOPJv/BiSO3YDh38w1j2SKuHrXQf0OjmvAH0+hHFqL9xB3yUi9QhNdewI2qJpuL ZW+qwxiqmG2QSxP/UYJUegm22+jlpY4JRv6mKkW4vlUe5sZ0oNl+oPig8k0Zs5SfntY38d RAOk0peXlx9XpXBhRZrl0I5t9JQSYQ4BHXpSh6enTD4d1rBZt2m5BoovbeNaajQodpzl2Z bmjzSuPSuefaPS033CdUNT9KP/qQzjorpiRw+l0pwcBdBbhCoIAeICWrnvwzYfHKp/TBRO wKscA6yiwQQtvLRkSlWskaMkn4DvRs8LN20j3ksG/sK4YlfP93u4hiqsrtxZWA== Received: from nuc (192-0-220-237.cpe.teksavvy.com [192.0.220.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: markj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gMTkp73xgz186L; Fri, 22 May 2026 15:30:58 +0000 (UTC) (envelope-from markj@freebsd.org) Date: Fri, 22 May 2026 11:30:57 -0400 From: Mark Johnston To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8deebce931fa - main - kernel: Enable -fstack-protector-strong by default Message-ID: References: <6a106e35.1de09.3dc6a77e@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 22, 2026 at 06:22:10PM +0300, Konstantin Belousov wrote: > On Fri, May 22, 2026 at 02:54:45PM +0000, Mark Johnston wrote: > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=8deebce931fa9b469cf28a082038a64caf972602 > > > > commit 8deebce931fa9b469cf28a082038a64caf972602 > > Author: Mark Johnston > > AuthorDate: 2026-05-22 14:45:52 +0000 > > Commit: Mark Johnston > > CommitDate: 2026-05-22 14:45:52 +0000 > > > > kernel: Enable -fstack-protector-strong by default > > > > This extends stack canary use to all functions which define arrays on > > the stack, not just those which operate on byte buffers. This option > > would have made it harder to exploit SA-26:18.setcred and > > SA-26:08.rpcsec_gss. > > > > The change bloats the amd64 kernel text by about 350KB and increases the > > number of covered functions from ~1500 to ~9000 (within the kernel > > itself, i.e., not counting kernel modules). > > > > Reviewed by: olce, olivier, emaste > > MFC after: 2 weeks > > Differential Revision: https://reviews.freebsd.org/D56870 > > --- > > sys/conf/kern.mk | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sys/conf/kern.mk b/sys/conf/kern.mk > > index af7b1589c5cd..b87583db21c5 100644 > > --- a/sys/conf/kern.mk > > +++ b/sys/conf/kern.mk > > @@ -235,7 +235,7 @@ CFLAGS+= -fwrapv > > # Stack Smashing Protection (SSP) support > > # > > .if ${MK_SSP} != "no" > > -CFLAGS+= -fstack-protector > > +CFLAGS+= -fstack-protector-strong > > .endif > > Can ssp turned off from the kernel config? Yes, add "makeoptions WITHOUT_SSP=1". Of course, that disables SSP entirely.