From owner-cvs-all@FreeBSD.ORG Sun Jul 3 01:10:23 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.ORG Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA42E16A8E1; Sun, 3 Jul 2005 00:58:38 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2E55144684; Sun, 3 Jul 2005 00:42:56 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id 922356DCE8; Sat, 2 Jul 2005 17:38:11 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id D15905C9AA for ; Tue, 25 Jan 2005 01:53:42 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id AAB9C559B5 for ; Tue, 25 Jan 2005 09:53:42 +0000 (GMT) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id 67ACB16A53F; Tue, 25 Jan 2005 09:53:39 +0000 (GMT) Delivered-To: ps@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id 5C0CA16A4D0; Tue, 25 Jan 2005 09:53:37 +0000 (GMT) Delivered-To: src-committers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 272D016A4CF; Tue, 25 Jan 2005 09:53:36 +0000 (GMT) Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F27C43D1F; Tue, 25 Jan 2005 09:53:35 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id j0P9rX7M080082; Tue, 25 Jan 2005 10:53:33 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Andrey Chernov From: "Poul-Henning Kamp" In-Reply-To: Your message of "Tue, 25 Jan 2005 12:42:26 +0300." <20050125094226.GA28188@nagual.pp.ru> Message-ID: <80081.1106646813@critter.freebsd.dk> Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on elvis.mu.org X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.1 X-Spam-Level: Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern sys_generic.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 01:10:23 -0000 X-Original-Date: Tue, 25 Jan 2005 10:53:33 +0100 X-List-Received-Date: Sun, 03 Jul 2005 01:10:23 -0000 In message <20050125094226.GA28188@nagual.pp.ru>, Andrey Chernov writes: >On Tue, Jan 25, 2005 at 09:15:32AM +0000, Poul-Henning Kamp wrote: >> sys/kern sys_generic.c >> Log: >> Previously a read of zero bytes got handled in devfs:vop_read() but I >> missed that when the vnode bypass was introduced. >> >> Deal with zero length transfers before we even get to fo_ops->fo_read(). > >Please back it out. Zero bytes read may affect atime, now not. No way. That would be just as bogus as the fact that open(2) doesn't affect atime. That is currently under discussion for reconsideration btw: Today atime is not affected if you open and mmap a file. Likewise I belive sendfile would not update atime either. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.