From owner-svn-ports-head@freebsd.org Sun Oct 15 14:05:06 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A6214E43EBE; Sun, 15 Oct 2017 14:05:06 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 80CC477858; Sun, 15 Oct 2017 14:05:06 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v9FE55Su040369; Sun, 15 Oct 2017 14:05:05 GMT (envelope-from madpilot@FreeBSD.org) Received: (from madpilot@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v9FE54vm040358; Sun, 15 Oct 2017 14:05:04 GMT (envelope-from madpilot@FreeBSD.org) Message-Id: <201710151405.v9FE54vm040358@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: madpilot set sender to madpilot@FreeBSD.org using -f From: Guido Falsi Date: Sun, 15 Oct 2017 14:05:04 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r452147 - in head: . Mk Mk/Uses databases/qdbm databases/qdbm-plus math/msieve multimedia/vlc net/linphone net/mediastreamer ports-mgmt/pkg security/putty X-SVN-Group: ports-head X-SVN-Commit-Author: madpilot X-SVN-Commit-Paths: in head: . Mk Mk/Uses databases/qdbm databases/qdbm-plus math/msieve multimedia/vlc net/linphone net/mediastreamer ports-mgmt/pkg security/putty X-SVN-Commit-Revision: 452147 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Oct 2017 14:05:06 -0000 Author: madpilot Date: Sun Oct 15 14:05:04 2017 New Revision: 452147 URL: https://svnweb.freebsd.org/changeset/ports/452147 Log: Retire WITHOUT_DEBUG flag. The flag has partial support across the tree, and the same effect can be obtained by using ".undef WITH_DEBUG". Reviewed by: mat, rene Approved by: portmgr (rene) Differential Revision: https://reviews.freebsd.org/D12548 Modified: head/Mk/Uses/cargo.mk head/Mk/bsd.port.mk head/UPDATING head/databases/qdbm-plus/Makefile head/databases/qdbm/Makefile head/math/msieve/Makefile head/multimedia/vlc/Makefile head/net/linphone/Makefile head/net/mediastreamer/Makefile head/ports-mgmt/pkg/Makefile head/security/putty/Makefile Modified: head/Mk/Uses/cargo.mk ============================================================================== --- head/Mk/Uses/cargo.mk Sun Oct 15 13:31:43 2017 (r452146) +++ head/Mk/Uses/cargo.mk Sun Oct 15 14:05:04 2017 (r452147) @@ -103,7 +103,7 @@ CARGO_INSTALL_ARGS+= --features='${CARGO_FEATURES}' CARGO_TEST_ARGS+= --features='${CARGO_FEATURES}' .endif -.if !defined(WITH_DEBUG) || defined(WITHOUT_DEBUG) +.if !defined(WITH_DEBUG) CARGO_BUILD_ARGS+= --release CARGO_TEST_ARGS+= --release .else Modified: head/Mk/bsd.port.mk ============================================================================== --- head/Mk/bsd.port.mk Sun Oct 15 13:31:43 2017 (r452146) +++ head/Mk/bsd.port.mk Sun Oct 15 14:05:04 2017 (r452147) @@ -337,6 +337,9 @@ FreeBSD_MAINTAINER= portmgr@FreeBSD.org # passed to the compiler by setting DEBUG_FLAGS. It is # set to "-g" at default. # +# NOTE: to override a globally defined WITH_DEBUG at a +# later time ".undef WITH_DEBUG" can be used +# # WITH_DEBUG_PORTS - A list of origins for which WITH_DEBUG will be set # # WITHOUT_SSP - Disable SSP. @@ -1681,7 +1684,7 @@ CFLAGS:= ${CFLAGS:C/${_CPUCFLAGS}//} .endif # Reset value from bsd.own.mk. -.if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG) +.if defined(WITH_DEBUG) .if !defined(INSTALL_STRIPPED) STRIP= #none MAKE_ENV+= DONTSTRIP=yes Modified: head/UPDATING ============================================================================== --- head/UPDATING Sun Oct 15 13:31:43 2017 (r452146) +++ head/UPDATING Sun Oct 15 14:05:04 2017 (r452147) @@ -5,6 +5,17 @@ they are unavoidable. You should get into the habit of checking this file for changes each time you update your ports collection, before attempting any port upgrades. +20171015: + AFFECTS: people using WITHOUT_DEBUG + AUTHOR: madpilot@FreeBSD.org + + The WITHOUT_DEBUG flag has been retired. It's only purpose was + to override a global WITH_DEBUG, if that was defined, but many + ports were ignoring such flag even if honouring WITH_DEBUG. + + The same effect can be obtained using ".undef WITH_DEBUG" without + any special support in port Makefiles. + 20171012: AFFECTS: users of security/openssh-portable AUTHOR: bdrewery@FreeBSD.org Modified: head/databases/qdbm-plus/Makefile ============================================================================== --- head/databases/qdbm-plus/Makefile Sun Oct 15 13:31:43 2017 (r452146) +++ head/databases/qdbm-plus/Makefile Sun Oct 15 14:05:04 2017 (r452147) @@ -27,7 +27,7 @@ CXXFLAGS+= -fsigned-char -fPIC INSTALL_TARGET= install-strip post-patch: -.if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG) +.if defined(WITH_DEBUG) @${REINPLACE_CMD} 's/-DNDEBUG//' ${WRKSRC}/Makefile.in .endif Modified: head/databases/qdbm/Makefile ============================================================================== --- head/databases/qdbm/Makefile Sun Oct 15 13:31:43 2017 (r452146) +++ head/databases/qdbm/Makefile Sun Oct 15 14:05:04 2017 (r452147) @@ -30,7 +30,7 @@ INSTALL_TARGET= install-strip PORTDOCS= ChangeLog NEWS post-patch: -.if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG) +.if defined(WITH_DEBUG) @${REINPLACE_CMD} 's/-DNDEBUG//' ${WRKSRC}/Makefile.in .endif Modified: head/math/msieve/Makefile ============================================================================== --- head/math/msieve/Makefile Sun Oct 15 13:31:43 2017 (r452146) +++ head/math/msieve/Makefile Sun Oct 15 14:05:04 2017 (r452147) @@ -28,7 +28,7 @@ OPTIONS_DEFAULT= OPTIMIZED_CFLAGS .if ${PORT_OPTIONS:MOPTIMIZED_CFLAGS} CFLAGS+= -O3 -ffast-math -.if defined(WITHOUT_DEBUG) || !defined(WITH_DEBUG) +.if !defined(WITH_DEBUG) CFLAGS+= -fomit-frame-pointer -DNDEBUG .endif .endif Modified: head/multimedia/vlc/Makefile ============================================================================== --- head/multimedia/vlc/Makefile Sun Oct 15 13:31:43 2017 (r452146) +++ head/multimedia/vlc/Makefile Sun Oct 15 14:05:04 2017 (r452147) @@ -54,7 +54,7 @@ CONFIGURE_ARGS= --enable-avcodec --enable-avformat --e --disable-wasapi --disable-x26410b \ --with-kde-solid=${PREFIX}/share/apps/solid/actions \ ac_cv_search_pthread_rwlock_init=-pthread -.if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG) +.if defined(WITH_DEBUG) CONFIGURE_ARGS+=--enable-debug .endif CPPFLAGS+= -I${LOCALBASE}/include Modified: head/net/linphone/Makefile ============================================================================== --- head/net/linphone/Makefile Sun Oct 15 13:31:43 2017 (r452146) +++ head/net/linphone/Makefile Sun Oct 15 14:05:04 2017 (r452147) @@ -55,7 +55,7 @@ UPNP_LIB_DEPENDS= libupnp.so:devel/upnp VIDEO_CONFIGURE_ENABLE= video -.if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG) +.if defined(WITH_DEBUG) CONFIGURE_ARGS+=--enable-debug .endif Modified: head/net/mediastreamer/Makefile ============================================================================== --- head/net/mediastreamer/Makefile Sun Oct 15 13:31:43 2017 (r452146) +++ head/net/mediastreamer/Makefile Sun Oct 15 14:05:04 2017 (r452147) @@ -84,7 +84,7 @@ VPX_LIB_DEPENDS= libvpx.so:multimedia/libvpx XVIDEO_CONFIGURE_ENABLE=x11 xv XVIDEO_USE= XORG=videoproto,x11,xv -.if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG) +.if defined(WITH_DEBUG) CONFIGURE_ARGS+=--enable-debug .endif Modified: head/ports-mgmt/pkg/Makefile ============================================================================== --- head/ports-mgmt/pkg/Makefile Sun Oct 15 13:31:43 2017 (r452146) +++ head/ports-mgmt/pkg/Makefile Sun Oct 15 14:05:04 2017 (r452147) @@ -33,7 +33,7 @@ EXTRA_PATCHES= ${FILESDIR}/extra-patch-docs_pkg.8 .include -.if defined(WITH_DEBUG) && !defined(WITHOUT_DEBUG) +.if defined(WITH_DEBUG) MAKE_ARGS+= DEBUG_FLAGS="${DEBUG_FLAGS}" .endif Modified: head/security/putty/Makefile ============================================================================== --- head/security/putty/Makefile Sun Oct 15 13:31:43 2017 (r452146) +++ head/security/putty/Makefile Sun Oct 15 14:05:04 2017 (r452147) @@ -72,7 +72,7 @@ _COMPAT= -DNO_GSSAPI _COMPAT+= -DOMIT_UTMP -.if defined(WITH_DEBUG) && ${WITH_DEBUG} != "no" +.if defined(WITH_DEBUG) XFLAGS= -DDEBUG .endif