Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 09 Feb 2020 02:58:19 +0000
From:      bugzilla-noreply@freebsd.org
To:        python@FreeBSD.org
Subject:   [Bug 243971] [NEW PORT] www/py-gdown: Download files from google drive
Message-ID:  <bug-243971-21822-EocwMfBM00@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-243971-21822@https.bugs.freebsd.org/bugzilla/>
References:  <bug-243971-21822@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243971

--- Comment #2 from Shane <FreeBSD@ShaneWare.Biz> ---
I just thought requests[socks] was part of www/py-requests.

py-requests depends on py-urllib3 which optionally depends on py-pysocks, a=
nd
is on by default.

gdown passes any proxy options to requests through `sess.proxies =3D {...}`=
 then
the call to `sess.get()` is in a try block which catches proxy errors. That
should leave a nice failed message if trying to use a proxy with SOCKS
disabled/unavailable in py-urllib3.

https://github.com/wkentaro/gdown/blob/master/gdown/download.py#L66

So as gdown doesn't directly rely on or call py-pysocks, does that count as
needing to be listed as an optional port dependency? It does mean the proje=
cts
setup.py could use some adjustment.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-243971-21822-EocwMfBM00>