From owner-freebsd-net@FreeBSD.ORG  Fri Apr 20 06:16:36 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 36E6E106567B;
	Fri, 20 Apr 2012 06:16:36 +0000 (UTC)
	(envelope-from gnn@neville-neil.com)
Received: from vps.hungerhost.com (vps.hungerhost.com [216.38.53.176])
	by mx1.freebsd.org (Postfix) with ESMTP id 0D1C08FC18;
	Fri, 20 Apr 2012 06:16:36 +0000 (UTC)
Received: from [38.110.160.135] (port=63513 helo=[10.0.208.182])
	by vps.hungerhost.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.77)
	(envelope-from <gnn@neville-neil.com>)
	id 1SL791-0006I9-CG; Fri, 20 Apr 2012 02:16:35 -0400
From: George Neville-Neil <gnn@neville-neil.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Date: Thu, 19 Apr 2012 21:44:33 -0400
Message-Id: <280454D9-E233-4010-8810-588296FA19D1@neville-neil.com>
To: net@freebsd.org
Mime-Version: 1.0 (Apple Message framework v1257)
X-Mailer: Apple Mail (2.1257)
X-AntiAbuse: This header was added to track abuse,
	please include it with any abuse report
X-AntiAbuse: Primary Hostname - vps.hungerhost.com
X-AntiAbuse: Original Domain - freebsd.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - neville-neil.com
Cc: "Bjoern A. Zeeb" <bz@FreeBSD.org>
Subject: Question about fixing udp6_input...
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Apr 2012 06:16:36 -0000

Howdy,

At the moment the prototype for udp6_input() is the following:

int
udp6_input(struct mbuf **mp, int *offp, int proto)

and udp_input() looks like this:

void
udp_input(struct mbuf *m, int off)

As far as I can tell we immediately change **mp to *m and *offp to off
in udp6_input() and we also never use proto in the rest of the function.

Is there any reason to not make udp6_input() look exactly like udp_input() ?

Best,
George