Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Feb 2017 20:36:28 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r313707 - head/sys/dev/iscsi
Message-ID:  <201702132036.v1DKaSEM037923@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Mon Feb 13 20:36:28 2017
New Revision: 313707
URL: https://svnweb.freebsd.org/changeset/base/313707

Log:
  Remove M_PKTHDR from m_getm2() in icl_pdu_append_data().
  
  ip_data_mbuf is always appended to ip_bhs_mbuf, so it does not need own
  packet header.  This change first avoids allocation/initialization of the
  header, and then avoids dropping one when it later gets to socket buffer.
  
  MFC after:	2 weeks

Modified:
  head/sys/dev/iscsi/icl_soft.c

Modified: head/sys/dev/iscsi/icl_soft.c
==============================================================================
--- head/sys/dev/iscsi/icl_soft.c	Mon Feb 13 20:13:29 2017	(r313706)
+++ head/sys/dev/iscsi/icl_soft.c	Mon Feb 13 20:36:28 2017	(r313707)
@@ -1087,7 +1087,7 @@ icl_pdu_append_data(struct icl_pdu *requ
 
 	KASSERT(len > 0, ("len == 0"));
 
-	newmb = m_getm2(NULL, len, flags, MT_DATA, M_PKTHDR);
+	newmb = m_getm2(NULL, len, flags, MT_DATA, 0);
 	if (newmb == NULL) {
 		ICL_WARN("failed to allocate mbuf for %zd bytes", len);
 		return (ENOMEM);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702132036.v1DKaSEM037923>