From owner-freebsd-hackers@FreeBSD.ORG Thu Sep 29 18:21:40 2005 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3D40916A41F for ; Thu, 29 Sep 2005 18:21:40 +0000 (GMT) (envelope-from anderson@centtech.com) Received: from mh2.centtech.com (moat3.centtech.com [207.200.51.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id D108A43D49 for ; Thu, 29 Sep 2005 18:21:39 +0000 (GMT) (envelope-from anderson@centtech.com) Received: from [192.168.42.23] (andersonbox3.centtech.com [192.168.42.23]) by mh2.centtech.com (8.13.1/8.13.1) with ESMTP id j8TILco1030353 for ; Thu, 29 Sep 2005 13:21:38 -0500 (CDT) (envelope-from anderson@centtech.com) Message-ID: <433C30AB.2030409@centtech.com> Date: Thu, 29 Sep 2005 13:21:31 -0500 From: Eric Anderson User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.11) Gecko/20050914 X-Accept-Language: en-us, en MIME-Version: 1.0 To: freebsd-hackers@freebsd.org Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.82/1104/Wed Sep 28 17:20:40 2005 on mh2.centtech.com X-Virus-Status: Clean Subject: ufsstat implementation X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2005 18:21:40 -0000 I've been looking at the ufs code, and thinking about wedging in some statistic gathering pieces pretty much copied from the nfs code (and nfsstat) to provide nearly the same functionality. I realize that adding statistic gathering code would techinically reduce filesystem performance, so should I put a wrapper around the code pieces checking a sysctl, or use #ifdef's around it, or neither? Also - am I going about this the right way, or is there a better way to record these statistics? Thanks! Eric -- ------------------------------------------------------------------------ Eric Anderson Sr. Systems Administrator Centaur Technology Anything that works is better than anything that doesn't. ------------------------------------------------------------------------