From nobody Wed Feb 11 23:07:44 2026 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fBDc44vJKz6RhNM for ; Wed, 11 Feb 2026 23:07:48 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fBDc446Lsz3l1m; Wed, 11 Feb 2026 23:07:48 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770851268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vpAXG4NJK7VWBOVtMHMJh8s2/FBoWb/n7XP3/wVCElM=; b=mHE73MBGIzXbtZNuhPrLWdpLrk0DDqzH7MZBm4sTv4dP9pEI1rU/QLZGjlrU1cJNlZSs34 OsiEx41SLdADdsvKIbycRB+uoe8XRZawfFs0wcraBHrP5XaV1L6Serx0Ms9aLP9etsibms fMS+PaXJMQtbXKNUPSeOae3GaiFSS+VVJGmb0LtAYAGI0GBsrPKbsXEnWGQ5cxoepc/2eA 7P6j5qQK7Begc4zko84rSyKbGCsmMFRsTZJ6sTzH4rellQXokLSmNZte4ZuoYOMurzKiaC Lqr0Qzn17nR0obmKsIoyVhh/FknJ02a4l/FZ7ibUdTGDrOVJMyiyAT/KFurGoA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770851268; a=rsa-sha256; cv=none; b=bY0JYX5bmBGAm9g+76XcdujFewujGHp7oiK5aNCnZpE1DTVDFqt5VwzEMwWipVroc8WSmh LTYQTGdo5HovpHBwp+0Wm2Tl5AtthEMZG2b+3RBfmX4UFymMeOPVSfoTxGMmR85uOyBqCD RxucmMSMQFV0iLsquDOO9NIdEc6aDi0DnWtjar4S2mf+wGWseoodbmaj/DUOoCvMW08KKN Wjjpyuo9t8DUEu2nHqnfoT0yJFHLjfpN2ZiM6XUJR0qxpkMsLtxouiXICWaHzK/R3cN5ao ucx24fTKP5XZy+DVA3hFu/1aLdOdGR2Rf4W2YUiTvsqClHELIVcXQMRiN3F+7Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770851268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vpAXG4NJK7VWBOVtMHMJh8s2/FBoWb/n7XP3/wVCElM=; b=rhbxTD/SkQBuFOf8QhOkek4LQ9zxVaVVDBXF3DuAc4il7euyDFT/NrXaecDsVsmd923bm7 pB6YADT8UIr1J9yO7Jfn8ShsIahd8TpuHuHYtltX9zxSXs/Bt2z3pfsm6+RAE62sAQZbov HUe7VV0///Hxs4Lwozl67ayHuxX1jHz3v0jbmGUHgTq3lblF76yFcyTdKHzTIuRLK+ijc/ G3epetyUxfDw7CudXQJxM/IDNylXmjgG+ULntvp6VAnDz01Vh4QHiMJ2ZntzEoPz+z0fIz sgXtjfu97TKnQmAgPvwXEnvJjSoc1qgkwYwB7SZhx7mcgmQjtVO2K1IT+Giuvg== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fBDc40NNCzDXJ; Wed, 11 Feb 2026 23:07:47 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Wed, 11 Feb 2026 15:07:44 -0800 From: Gleb Smirnoff To: Martin Mayer Cc: Zhenlei Huang , "freebsd-net@freebsd.org" Subject: Re: promisc/netgraph question Message-ID: References: <20260130234931.073ec5df@nuclight.lan> List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="jRTQLb2ymzMljmMA" Content-Disposition: inline In-Reply-To: --jRTQLb2ymzMljmMA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Feb 07, 2026 at 10:26:07AM +0000, Martin Mayer wrote: M> Based on the previous comments, I can conclude that the current behavior can be called a bug. M> How should we proceed? Does somebody who is more familiar with the topic open a bug or should I register to the bugtracker and open an issue? Can you please test the attached patch? -- Gleb Smirnoff --jRTQLb2ymzMljmMA Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename=if_ethersubr.c.patch commit eda1e75240758a12c58599b831961016cfcb1e03 Author: Gleb Smirnoff Date: Wed Feb 11 15:04:43 2026 -0800 ethernet: restore M_PROMISC if ng_ether(4) or bridge(4) return a packet diff --git a/sys/net/if_ethersubr.c b/sys/net/if_ethersubr.c index 812a31595df9..fac0d9fb6462 100644 --- a/sys/net/if_ethersubr.c +++ b/sys/net/if_ethersubr.c @@ -515,6 +515,7 @@ static void ether_input_internal(struct ifnet *ifp, struct mbuf *m) { struct ether_header *eh; + u_int pflag; u_short etype; if ((ifp->if_flags & IFF_UP) == 0) { @@ -640,6 +641,7 @@ ether_input_internal(struct ifnet *ifp, struct mbuf *m) if (ifp->if_l2com != NULL) { KASSERT(ng_ether_input_p != NULL, ("%s: ng_ether_input_p is NULL", __func__)); + pflag = m->m_flags & M_PROMISC; m->m_flags &= ~M_PROMISC; (*ng_ether_input_p)(ifp, &m); if (m == NULL) { @@ -647,6 +649,7 @@ ether_input_internal(struct ifnet *ifp, struct mbuf *m) return; } eh = mtod(m, struct ether_header *); + m->m_flags |= pflag; } /* @@ -660,6 +663,7 @@ ether_input_internal(struct ifnet *ifp, struct mbuf *m) * should be re-examined. */ if (ifp->if_bridge != NULL || (m->m_flags & M_BRIDGE_INJECT) != 0) { + pflag = m->m_flags & M_PROMISC; m->m_flags &= ~M_PROMISC; BRIDGE_INPUT(ifp, m); if (m == NULL) { @@ -667,6 +671,7 @@ ether_input_internal(struct ifnet *ifp, struct mbuf *m) return; } eh = mtod(m, struct ether_header *); + m->m_flags |= pflag; } #if defined(INET) || defined(INET6) --jRTQLb2ymzMljmMA--