From nobody Fri Oct 3 21:39:47 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cdhs54kqSz69H44 for ; Fri, 03 Oct 2025 21:39:53 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cdhs52ss1z47KJ for ; Fri, 03 Oct 2025 21:39:53 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-x72b.google.com with SMTP id af79cd13be357-856222505eeso316189285a.1 for ; Fri, 03 Oct 2025 14:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759527591; x=1760132391; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=XKrCMi07STkd0L6TZ9UX+Nf85A1RReWvtBQ/sVd+omM=; b=gxQ2/nAdN19w68BRjpTZH57tRVFWqNqEMiF2g+bm1nzVoZIGRMFKAqbYuUIpHseRWf jHWnptcmfXKvrUtqSDsa64fgVOfwSgMc/FNiwgzeiENJZv9sIP4hp9EL+MP7JTP5eRms J34t0u9zjCr/yqLNy8aa3nTy5vxnt8pifuDQoyXmeAmgLlqEzeh/Henrc2pTFikbNQTH wZTojwZX+hKMxxDO3pybN9AYllHeeND2Aj7XPUoFYyljhYIKwLQNQBpVAK+wpluoOrrA JtqWd04DoKGK0HYF7hOUioehMg/Zz+Tk3VpgxsTFU9GMHugrJs/tF7m+ImZAFpwZOc0A SWsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759527591; x=1760132391; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XKrCMi07STkd0L6TZ9UX+Nf85A1RReWvtBQ/sVd+omM=; b=nCUzfh67i38jnJSP8jcCKilsd1IFVAb73jdXZtlUsrz2/vdw3tL/qfCReJonCDqdO1 /p2bskLmXim2RK41ll4sZou09PDnfd8SyMO4Frgr40Uu8LHBdlnGBKxcuPXG5r1PrWBp XH7SntuteV8ufFlUIj4iqSemCCcm3x9d2i41JTvzk42W8wYDaM4zgoWzvTP1hJOprLzT KyTXhE4s9gr+p4KyXZ9PXcOjZbXaehN/5jeA11j2C/A5+tsnBKAWOdvzFjIpVLpcla5A 1I9BCnxx8uOFk08fqrGf2vrmhJ+6khK3p0ABkmpveW2e7wzckHIMxJi4MIlR0iQb3oPZ rbiQ== X-Forwarded-Encrypted: i=1; AJvYcCWA75Tkj0vnab88GJpqYk+zENY6QdLgUzMbyc9eV5BSFklrhfJx7/4h6hBr3eAKIqK0du0/q7pKBIhRTp3gaIk8w2BIvQ==@freebsd.org X-Gm-Message-State: AOJu0Yz6d+KrACMUeKsPA6/ZnjeVjxIiloA5OK79vepRXdADCR305xTQ QNyDBhG0RcLcZl/fFbPNXgpDpC/B6vCM1R/aALfMf/owhLK2sn5jzVhME6vzBu+q X-Gm-Gg: ASbGnct7DwMopXXButThNueRIwXuUveNoTnVvDPc/nyHHkgWtFf4hQLHDzm5MayiO94 W8OY8DiI7XBNqcKV0eOcRPYF+21smlj0zzQMMuIATOI1y6M9SlbgU3DjEwVXqWoHc7dHfu1mXOx AvgoWQDzueuMYQ011lC36WslAwfS2iIv3EETSFoGrG8j5c7dvTxCigmPM+ILUreRa7IZRFFU5nb IiwJW+ld/WD6ykU8Upqj5rw/OWsVtoFGipBM0688KPMHeH/NUX3yFo7JNjk12ErYRdT4DQku0hM oWeGEZpXlo0gTra4YegAD/XzHdaw17DuQvRE43UOaiE0PO421POkWsGLmIFGg2pcSiao3rOmd3/ cOWd9pwPcpYGXsef+HnZ3pwA6LkBHArbNQC9LiG/S8zguY4janrtb1VXRR/VP X-Google-Smtp-Source: AGHT+IEGOPORN+AtSNv8W+zntsmmw9qTucIgzmmfyiQdiQQsjXTyLoQPcmA2PqHnJSdAydCU3WcHig== X-Received: by 2002:a05:620a:28cd:b0:85d:3c32:c412 with SMTP id af79cd13be357-87a36779655mr582432385a.5.1759527590922; Fri, 03 Oct 2025 14:39:50 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id af79cd13be357-877725550fcsm540520285a.21.2025.10.03.14.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Oct 2025 14:39:50 -0700 (PDT) Date: Fri, 3 Oct 2025 17:39:47 -0400 From: Mark Johnston To: Kyle Evans Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1953a12ee2cd - main - flua: support our flua modules in the bootstrap flua Message-ID: References: <202510031810.593IAZE9008541@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202510031810.593IAZE9008541@gitrepo.freebsd.org> X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cdhs52ss1z47KJ On Fri, Oct 03, 2025 at 06:10:35PM +0000, Kyle Evans wrote: > The branch main has been updated by kevans: > > URL: https://cgit.FreeBSD.org/src/commit/?id=1953a12ee2cde1afacb3e3f7612d89695c96e04f > > commit 1953a12ee2cde1afacb3e3f7612d89695c96e04f > Author: Kyle Evans > AuthorDate: 2025-10-03 18:09:03 +0000 > Commit: Kyle Evans > CommitDate: 2025-10-03 18:09:14 +0000 > > flua: support our flua modules in the bootstrap flua > > This version builds every module into the flua binary itself, since all > of the bootstrap tools are built -DNO_SHARED. As a result, we also > cannot dlsym(), so we can't really discover the names of our newly > builtin modules. Instead, just build out a linker set with all of our > luaopen_*() functions to register everything up-front. > > Building in all of the modules isn't strictly necessary, but it means > that we have an example of how to add a bootstrap module everywhere you > go and one doesn't need to consider whether bootstrap flua can use a > module when writing scripts. On my build machine, the consequence on > our binary size is an increase from around 1.6M -> 1.9M, which isn't > really that bad. > > .lua modules can install into their usual path below $WORLDTMP/legacy > and we'll pick them up automagically by way of the ctor that sets up > LUA_PATH early on. > > Reviewed by: bapt, emaste > Differential Revision: https://reviews.freebsd.org/D51890 This breaks cross-building from other OSes since linker.h and kenv.h aren't available. I guess we can safely exclude those from the bootstrap build? It could be done conditionally on ${.MAKE.OS} perhaps, but it's probably better to be consistent.