From owner-freebsd-current Mon Mar 17 13: 8: 3 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F0B4837B401 for ; Mon, 17 Mar 2003 13:08:01 -0800 (PST) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3B85A43F85 for ; Mon, 17 Mar 2003 13:07:59 -0800 (PST) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (smmsp@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.7/8.12.7) with ESMTP id h2HL7rFU035782; Mon, 17 Mar 2003 13:07:53 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.7/8.12.7/Submit) id h2HL7rHA035781; Mon, 17 Mar 2003 13:07:53 -0800 (PST) Date: Mon, 17 Mar 2003 13:07:53 -0800 From: "David O'Brien" To: cjclark@alum.mit.edu Cc: current@FreeBSD.org Subject: Re: Create linker.hints at boot Message-ID: <20030317210753.GA35762@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org Mail-Followup-To: David O'Brien , cjclark@alum.mit.edu, current@FreeBSD.org References: <20030315000920.GA69495@blossom.cjclark.org> <20030315032742.3AE132A7EA@canning.wemm.org> <20030317082834.GC24317@blossom.cjclark.org> <20030317171112.GA32128@dragon.nuxi.com> <20030317204319.GA98963@blossom.cjclark.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030317204319.GA98963@blossom.cjclark.org> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Mar 17, 2003 at 12:43:19PM -0800, Crist J. Clark wrote: > On Mon, Mar 17, 2003 at 09:11:12AM -0800, David O'Brien wrote: > > On Mon, Mar 17, 2003 at 12:28:34AM -0800, Crist J. Clark wrote: > > > +kldxref_start () { > > > + if [ -z "$kldxref_module_path" ]; then > > > + MODULE_PATHS=`sysctl -n kern.module_path` > > > + else > > > + MODULE_PATHS="$kldxref_module_path" > > > + fi > > > > Please change the logic to positive logic: > > > > if [ -n "$kldxref_module_path" ]; then > > MODULE_PATHS="$kldxref_module_path" > > else > > MODULE_PATHS=`sysctl -n kern.module_path` > > fi > > Is there a technical reason for that or is it just a "style" issue? Style, easier to read out loud, easier to understand w/o having to think. Just like this is hard to "read". It certainly doesn't do what one reads out loud: "if not string compaire equal". if (!strcmp(a,b) { printf("same\n"); } To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message