From owner-freebsd-bugs@freebsd.org  Sat Sep 12 04:05:24 2015
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 51C59A0268B
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Sat, 12 Sep 2015 04:05:24 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3E80F1C57
 for <freebsd-bugs@FreeBSD.org>; Sat, 12 Sep 2015 04:05:24 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t8C45OW7082431
 for <freebsd-bugs@FreeBSD.org>; Sat, 12 Sep 2015 04:05:24 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 202607] [panic] Poudriere umounting file systems causes
 'solaris assert: avl_is_empty(&dn->dn_dbufs)' panic
Date: Sat, 12 Sep 2015 04:05:24 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: gibbs@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-202607-8-n1satPGB7D@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-202607-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-202607-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Sep 2015 04:05:24 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202607

--- Comment #4 from Justin T. Gibbs <gibbs@FreeBSD.org> ---
(In reply to Xin LI from comment #2)
I spent some more time this evening reviewing the code. I believe that removing
the assert is safe. However, it would be good to assert that the only dbufs on
the dnode are either for the bonus buffer or in the evicting state. This should
hold true because the dnode free paths at higher levels (e.g. ZPL and ZVOL)
enforce mutual exclusion between reads/writes and frees. 

Currently, dbuf_rele_and_unlock() doesn't contain any logic to ensure regular
(not bonus buffer) dbufs are immediately evicted for free'd dnodes. So if, due
to a bug or regression, a dbuf for a dnode being freed is held during the call
to dnode_sync_free() , the dbuf and dnode will stick around in memory until
memory pressure evicts the dbuf. From the perspective of dnode_sync_free() and
even memory usage, this is no big deal, but it probably indicates a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.