From owner-freebsd-ports@FreeBSD.ORG Wed May 2 15:44:19 2007 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5968616A400; Wed, 2 May 2007 15:44:19 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id E70B713C44B; Wed, 2 May 2007 15:44:18 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l42FiHpw073907; Wed, 2 May 2007 10:44:17 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l42FiH9F073906; Wed, 2 May 2007 10:44:17 -0500 (CDT) (envelope-from brooks) Date: Wed, 2 May 2007 10:44:17 -0500 From: Brooks Davis To: Andrey Chernov , current@freebsd.org, ports@freebsd.org, Alfred Perlstein , David Schultz Message-ID: <20070502154417.GA73631@lor.one-eyed-alien.net> References: <20070501003935.GA1043@nagual.pp.ru> <20070501083009.GA4627@nagual.pp.ru> <20070501160645.GA9333@nagual.pp.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: <20070501160645.GA9333@nagual.pp.ru> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Wed, 02 May 2007 10:44:17 -0500 (CDT) Cc: Subject: Re: HEADS DOWN (was Re: HEADS UP: putenv, setenv, unsetenv, getenv changes) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2007 15:44:19 -0000 --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 01, 2007 at 08:06:45PM +0400, Andrey Chernov wrote: > All backed out. >=20 > Not because I admit they are technically wrong and not because of bug > reports (I receive nothing). But because I surprisingly meets so > strong opposition and resistance so lost any desire to continue that. >=20 > Anyone who interested in POSIX can dig out what changes and how > through cvs diffs. FreeBSD does care about standards and your change probably makes sense, but the way you went about it was all wrong. First, you committed an API/ABI change to libc without even performing a buildworld. You should be commended for fixing the problems quickly, but the breakage rightfully made people nervous. Second and more importantly, you committed an API/ABI change to libc without any discussion beforehand. Had you done so, this almost certainly would have gone smootly. Third, your waving of the POSIX flag when people responded negativly did not help. While following POSIX is generally a good idea, blindly doing so is not. Given that *env() is a lousy API by any reasonable measure, sounder arguments such as those raised by jhb were needed. I hope you will engage in productive disussion of this change and should it be accepted (and I think it will) commit it again. -- Brooks --AhhlLboLdkugWU4S Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGOLHQXY6L6fI4GtQRAnU9AKDafz9ZbXPTRnWaleCZB44/LPVfyQCgjLza w4JwI2DfJUuXgtAFQim2Ft4= =A+NR -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--