Date: Tue, 28 Feb 2023 20:32:22 +0100 From: Matthias Andree <mandree@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org>, Charlie Li <vishwin@freebsd.org>, "Tobias C. Berner" <tcberner@gmail.com> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: a9d9d3a42723 - main - lang/python: Revert "add bytecode trigger" Message-ID: <baff881d-7ab5-16c3-ec04-8ed6e95e343a@FreeBSD.org> In-Reply-To: <20230228075455.b7otamo7ezahtqxi@aniel.nours.eu> References: <202302272105.31RL593a014619@gitrepo.freebsd.org> <20230228075455.b7otamo7ezahtqxi@aniel.nours.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 28.02.23 um 08:54 schrieb Baptiste Daroussin: > On Mon, Feb 27, 2023 at 09:05:09PM +0000, Matthias Andree wrote: >> The branch main has been updated by mandree: >> >> URL: https://cgit.FreeBSD.org/ports/commit/?id=a9d9d3a4272303bf226b9deb55c42303e4fcebdc >> >> commit a9d9d3a4272303bf226b9deb55c42303e4fcebdc >> Author: Matthias Andree <mandree@FreeBSD.org> >> AuthorDate: 2023-02-27 21:01:32 +0000 >> Commit: Matthias Andree <mandree@FreeBSD.org> >> CommitDate: 2023-02-27 21:04:52 +0000 >> >> lang/python: Revert "add bytecode trigger" >> >> This reverts commit c17ddfbf66e2801ec620d49979aca3d7077d7002. >> >> This causes breakage on several ports, and the next iteration >> requires a full exp-run. See: >> >> Differential Revision: https://reviews.freebsd.org/D34739 > > This is not how this is supposed to be done! while you have a point about the > issue and the full exp-run, the issue is easily fixable, you should have let > time to the committer to revert by himself, by asking him to revert instead of > abruply reverting! > > Best regards, > Bapt Am 28.02.23 um 06:44 schrieb Tobias C. Berner: > Moin moin > > So you reverted the first major change to the python framework in ages > due to a leaf-port breakin non-fatally? > This looks a little bit like overstepping the bounds of good taste a bit to me. Baptiste, Tobias, First, let's get the timeline straight: Feb 15, Charlie commits. Feb 18, Antoine claims the bug via mailing list. Feb 18, Mathieu asks why this was committed without prior -exp run, via reviews.freebsd.org - silence - Feb 27, Matthias (yours truly) reverts that breaking change Feb 27 - 28, people pick at Matthias with emotional and non-technical reasons which are all besides the factual point. There was NO acknowledgment of the bug, no hint that anyone was working, and we had broken sphinx and breathe ports, so we needed to fix things. Then, half of the messages on IRC, mailing list, and the reviews were also non-technical, attacking me instead of the bug in Charlie's stuff and revealing who was getting touchy. All in all, can we now please stop confusing cause and effect, and can those who have been touchy now please grow up? Thanks everyone. -- Matthias Andree FreeBSD ports committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?baff881d-7ab5-16c3-ec04-8ed6e95e343a>