From owner-cvs-sys Fri Aug 16 05:19:25 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id FAA28065 for cvs-sys-outgoing; Fri, 16 Aug 1996 05:19:25 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id FAA28057; Fri, 16 Aug 1996 05:18:22 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.12/8.6.9) id WAA20660; Fri, 16 Aug 1996 22:09:11 +1000 Date: Fri, 16 Aug 1996 22:09:11 +1000 From: Bruce Evans Message-Id: <199608161209.WAA20660@godzilla.zeta.org.au> To: ache@nagual.ru, peter@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> restore nsccons variable from rev 1.115 that was deleted in rev 1.136 >> during phk's staticize/cleanup commits. pstat needs it, the MAXCONS >> option is not visible anywhere else, and pstat uses it to find the bounds >> of the sccons[MAXCONS] array, which varies. >As I remember, poor nsccons variable was deleted/restored already >2-3 times. Even direct comment about pstat not protect it from removing. >Do we have any better way to protect it? It hasn't been restored before (but was missing until rev.1.115. The delete/restores occurred for almost every serial driver. I think declaring the variables as `static const' is good enough. Comments saying that they are used by pstat become silly if they are ever used by other utilities. Bruce