From owner-freebsd-net@FreeBSD.ORG Thu Dec 11 21:38:06 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 01594106564A; Thu, 11 Dec 2008 21:38:06 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.236]) by mx1.freebsd.org (Postfix) with ESMTP id 24B298FC22; Thu, 11 Dec 2008 21:38:04 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so1047701rvf.43 for ; Thu, 11 Dec 2008 13:38:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=6PtEuUNqYyP9mJFuKpNjjXDfyp2LXS8p+viVpNCdBMY=; b=E1XLX6jejNFgbsSHorze3uM42F7ZTU4q4KlxftgmCydwV+KgfK3xCn21fqk74AT0OU IcH82x2gsWE/LgrOcekuK4W5/c+tGihnWm6p0SXF8y03BgTTpBmedRGPjLVk8Q7rG+al K++PHlMCUE4rHnNJjx2XVM11N+vizAr4/Omd8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=lNATF6M/VdcPELMlWs0NkvfjOa9GpVdtpAhDX+cKGeJrCGhbsoLqkLTIQL+gZGTlmG 4ZeJmfISQUBR29GhDEWVEFT9SVw35qHVNixUrnH3SEdS6/l/JoKHhyMf5irS+K13ShCt tT0QTCchsmiV75QtDNpH/xMuT/7g/xHM7pDVg= Received: by 10.141.48.6 with SMTP id a6mr1504265rvk.36.1229031484656; Thu, 11 Dec 2008 13:38:04 -0800 (PST) Received: by 10.141.142.3 with HTTP; Thu, 11 Dec 2008 13:38:04 -0800 (PST) Message-ID: <3c1674c90812111338p69c33bd5sa26315cba4981011@mail.gmail.com> Date: Thu, 11 Dec 2008 13:38:04 -0800 From: "Kip Macy" Sender: mat.macy@gmail.com To: "Bruce M. Simpson" In-Reply-To: <49415977.6010307@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200812100740.mBA7eqjO034924@freefall.freebsd.org> <49415977.6010307@FreeBSD.org> X-Google-Sender-Auth: 1449877b1265c4a8 Cc: Qing Li , current@freebsd.org, freebsd-net@freebsd.org Subject: Re: last call for L2/L3 rewrite code review X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Dec 2008 21:38:06 -0000 I think that you're request to not monopolize the AF_INET slot is reasonable. Do you intend to merge bms_netdev before 8 branches (I'm guessing this coming summer)? Cheers, Kip On Thu, Dec 11, 2008 at 10:18 AM, Bruce M. Simpson wrote: > Hi, > > Just skimming this I notice it uses the if_afdata[AF_INET] pointer purely > for lltbl purposes; this clashes with the IGMPv3 code drop. > > Please look in the bms_netdev branch, where I introduce a 'struct ip_ifinfo' > to make more general use of that slot. IGMPv3 needs to store per-interface > state for AF_INET, so this slot really needs to be shared with other AF_INET > stuff. > > Looks like it needs to be updated for VIMAGE also, hopefully others more > familiar with this can help -- I am busy enough with non-programming > activity as it is to get up to speed on this, although I have at least > managed to print Julian's write-up... > > Other than that, it looks like a much needed improvement and we are all very > grateful for our work on this. > > thanks > BMS > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > -- If we desire respect for the law, we must first make the law respectable. - Louis D. Brandeis