From owner-cvs-all@FreeBSD.ORG Fri Aug 27 18:33:08 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 905FB16A4CF; Fri, 27 Aug 2004 18:33:08 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6BC7143D3F; Fri, 27 Aug 2004 18:33:08 +0000 (GMT) (envelope-from andre@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i7RIX8ub068974; Fri, 27 Aug 2004 18:33:08 GMT (envelope-from andre@repoman.freebsd.org) Received: (from andre@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i7RIX8fw068973; Fri, 27 Aug 2004 18:33:08 GMT (envelope-from andre) Message-Id: <200408271833.i7RIX8fw068973@repoman.freebsd.org> From: Andre Oppermann Date: Fri, 27 Aug 2004 18:33:08 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/hfa fore_receive.c src/sys/dev/idt idt_harp.c src/sys/dev/ppbus if_plip.c src/sys/i4b/driver i4b_ipr.c src/sys/net if_loop.c if_ppp.c if_sl.c if_spppsubr.c netisr.c rtsock.c src/sys/netgraph/atm/atmpif ng_atmpif_harp.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Aug 2004 18:33:08 -0000 andre 2004-08-27 18:33:08 UTC FreeBSD src repository Modified files: sys/dev/hfa fore_receive.c sys/dev/idt idt_harp.c sys/dev/ppbus if_plip.c sys/i4b/driver i4b_ipr.c sys/net if_loop.c if_ppp.c if_sl.c if_spppsubr.c netisr.c rtsock.c sys/netgraph/atm/atmpif ng_atmpif_harp.c sys/netinet ip_mroute.c sys/netinet6 ah_input.c esp_input.c sys/netipsec ipsec_input.c xform_ipip.c Log: Apply error and success logic consistently to the function netisr_queue() and its users. netisr_queue() now returns (0) on success and ERRNO on failure. At the moment ENXIO (netisr queue not functional) and ENOBUFS (netisr queue full) are supported. Previously it would return (1) on success but the return value of IF_HANDOFF() was interpreted wrongly and (0) was actually returned on success. Due to this schednetisr() was never called to kick the scheduling of the isr. However this was masked by other normal packets coming through netisr_dispatch() causing the dequeueing of waiting packets. PR: kern/70988 Found by: MOROHOSHI Akihiko MFC after: 3 days Revision Changes Path 1.23 +1 -1 src/sys/dev/hfa/fore_receive.c 1.6 +1 -2 src/sys/dev/idt/idt_harp.c 1.36 +2 -2 src/sys/dev/ppbus/if_plip.c 1.28 +1 -5 src/sys/i4b/driver/i4b_ipr.c 1.102 +1 -1 src/sys/net/if_loop.c 1.101 +2 -2 src/sys/net/if_ppp.c 1.124 +1 -1 src/sys/net/if_sl.c 1.114 +1 -1 src/sys/net/if_spppsubr.c 1.11 +5 -3 src/sys/net/netisr.c 1.117 +1 -1 src/sys/net/rtsock.c 1.2 +1 -1 src/sys/netgraph/atm/atmpif/ng_atmpif_harp.c 1.108 +1 -1 src/sys/netinet/ip_mroute.c 1.19 +2 -2 src/sys/netinet6/ah_input.c 1.25 +2 -2 src/sys/netinet6/esp_input.c 1.8 +2 -2 src/sys/netipsec/ipsec_input.c 1.10 +1 -1 src/sys/netipsec/xform_ipip.c