(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_RCPT(0.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cnxWy63Bfz3jlk --Apple-Mail=_793319AF-3625-4CB7-987D-C49A7E0E8610 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 16, 2025, at 10:29=E2=80=AFPM, Alexander Leidinger = wrote: >=20 > Am 2025-10-17 01:29, schrieb Rick Macklem: >> On Thu, Oct 16, 2025 at 4:21=E2=80=AFPM Rick Macklem = wrote: >>> Please be aware of the following snippets from "man 9 style": >>> In general code can be considered "new code" when it makes up about = 50% >>> or more of the file(s) involved. This is enough to break precedents = in >>> the existing code and use the current style guidelines. >>> Stylistic changes (including whitespace changes) are hard on the = source >>> repository and are to be avoided without good reason. >>> rick >> Just to be clear, I am not asking that this commit be reverted. >> I am just suggesting that you be aware that style(9) changes to >> extant code is not, in general, encouraged, afaik unless you are >> re-writing a large portion of the code (over 50%). >=20 > Does someone remember why? We have now the possibility to exclude = commits from the VCS attribution of lines to commits (git blame), as = such, does the reason of not doing it still hold? Hi Alexander, I=E2=80=99m not sure about the percentage Rick mentioned, but I = think Mark=E2=80=99s comment about avoiding merge conflicts is a key = point (for FreeBSD as well as downstream consumers of FreeBSD. Unnecessary churn can also make reconciling changes with other = sources, e.g., NetBSD, OpenBSD, more difficult for little to no gain. Cheers, -Enji PS Has anyone tried running `clang-format -i` on these files to see how = in compliance they are with style(9) *ducks to avoid flying fruit*?= --Apple-Mail=_793319AF-3625-4CB7-987D-C49A7E0E8610 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmjx8mwACgkQGpE5DjPs NJgPNxAAiHOrHvdLe3+SPeNz2kwegiCsJAc8upxKEtXjdfxiTVePizzd1o7ofcjU dQTXGU7T+r5W2PsdWz6NZG+ZksMBcZwJUxZPeBTkPqC2hYEtx9LWJBQRsim+ccU7 btvcDl/R7k53O8nw0DDc5jxKLY48ewHaDnPJ7juUiPkqcXCQnlUj678lLJ5Xehm6 24gSvqHjYKvxDTOXq4bSjBrfW2waz7m3b4RyyngvZnHYR1s9Llce1Z5VoR8v8g/f 49a1Wl+mAJl2vrFhGZvLnDBS5DKCNujW8MklofxIZjaVqTT6S40uRFVIG/Z/8B7C CdmPZjk9Y18L43TK5lSrkZpfaMcFkfF8eOxzXIcVI3eHJ0POs+ogSwr70aG8ohxH 3fPMeRS7WOpyt+rfSGcpFkbzKSPEDw/tmAZ7fWWwb+82EJSG65BmqgnUTp4urnsU x0MHbBcysigOFRTiqADmwWLHZzJk0bH3VrxIXf3SKuJu+iTe6YptUVVGJ18qmdxQ NmuTTVKNLaljSCTiKOD7J+aEFQhFOQTA3khD5xNkpftYIGHcRHlbgHXR/24/JQN5 54xcHWtOFhdwsXtQplCcc1GiOcve42x0zJ/f1ALuf41J/uQsDqaIzYfDs2XhixjI SBP4eiJdL3rAFuOQnT7kljg+HyFlsaCbNVIqii5LAXueqZB/ouU= =kw5l -----END PGP SIGNATURE----- --Apple-Mail=_793319AF-3625-4CB7-987D-C49A7E0E8610--