From owner-freebsd-stable@FreeBSD.ORG Tue Aug 16 17:31:03 2005 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 35C7A16A41F for ; Tue, 16 Aug 2005 17:31:03 +0000 (GMT) (envelope-from ah@crypta.net) Received: from mail.crypta.net (mail.crypta.net [83.136.131.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE51843D49 for ; Tue, 16 Aug 2005 17:31:02 +0000 (GMT) (envelope-from ah@crypta.net) Received: by mail.crypta.net (cryptobank/eProtect-smtpd, from userid 1001) id AB4C6ECD403; Tue, 16 Aug 2005 19:24:42 +0200 (CEST) Date: Tue, 16 Aug 2005 19:24:41 +0200 From: Andy Hilker To: freebsd-stable@freebsd.org Message-ID: <20050816172441.GD36329@mail.crypta.net> References: <20050812104352.GD2637@mail.crypta.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050812104352.GD2637@mail.crypta.net> User-Agent: Mutt/1.4.2.1i X-PGP-Key: http://wwwkeys.pgp.net:11371/pks/lookup?op=get&search=0xEC6E1071 X-PGP-Fingerprint: 9B2E 5892 AD93 D5C5 FB8E 3912 35D6 951B EC6E 1071 Organization: cryptobank - Andy Hilker Subject: Re: rc-ng problem with [procname] (e.g. kernel threaded procs) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2005 17:31:03 -0000 Hmh, no one interested in this issue? Or am i wrong with this issue? You (Andy Hilker) wrote: > Hi, > > i think I have found a problem with rc-ng scripts and procnames > including brackets (e.g. kernel threaded, like mysqld). > > Brackets [] are ignored, process will not be found and is regarded > as "not running". This breaks stop+status functions of rcng. The > following patch allows brackets in variable procname rc-ng scripts. > Maybe someone can review and fix this issue. > > It was relevant for me when using [mysqld]. > > bye, > Andy > > > # $FreeBSD: src/etc/rc.subr,v 1.31.2.1 2005/01/17 11:51:00 keramida Exp $ > --- rc.subr Thu Aug 11 15:18:52 2005 > +++ /etc/rc.subr Thu Aug 11 15:14:06 2005 > @@ -267,7 +267,7 @@ > _procnamebn=${_procname##*/} > _fp_args='_arg0 _argv' > _fp_match='case "$_arg0" in > - $_procname|$_procnamebn|${_procnamebn}:|"(${_procnamebn})")' > + "$_procname"|$_procnamebn|${_procnamebn}:|"(${_procnamebn})")' > fi > > _proccheck=' >