From owner-freebsd-current@FreeBSD.ORG Thu Aug 26 16:10:47 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2A7D016A4CE for ; Thu, 26 Aug 2004 16:10:47 +0000 (GMT) Received: from web.portaone.com (web.portaone.com [195.70.151.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 30DB043D31 for ; Thu, 26 Aug 2004 16:10:46 +0000 (GMT) (envelope-from sobomax@portaone.com) Received: from [192.168.0.20] (portacare.portaone.com [195.140.247.242]) (authenticated bits=0) by web.portaone.com (8.12.8p2/8.12.8) with ESMTP id i7QGAa5T036272 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 26 Aug 2004 18:10:37 +0200 (CEST) (envelope-from sobomax@portaone.com) Message-ID: <412E0B6C.8030001@portaone.com> Date: Thu, 26 Aug 2004 19:10:20 +0300 From: Maxim Sobolev Organization: Porta Software Ltd User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jun Su References: <412DF886.4030107@portaone.com> <412E0243.1050808@delphij.net> In-Reply-To: <412E0243.1050808@delphij.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: current@FreeBSD.org Subject: Re: [patch] bug in cpp's #ident handling in gcc 3.4 [Was: ccache with buildworld] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2004 16:10:47 -0000 Pointless. Instead of fixing the problem we will remove condition when this problem evidences itself. I am not advocating about keeping #ident, since it is completely orthogonal question. gcc claims that it supports #ident, there are problems in this support - they have to be fixed. Remember, there are lot of software out of /usr/src over which we have no control (e.g. /usr/ports), so that removing #ident will really be only half-measure, especially considering that the patch is readily available. -Maxim Jun Su wrote: > Maxim Sobolev wrote: > >> Hi there, >> >> I was looking into the problem with building world using ccache. It >> was failing with the following error message: >> >> /usr/src/lib/libc/rpc/key_call.c:33:10: extra tokens at end of #ident >> directive >> > > >> >> It would be nice to get it committed before 5.3 is out. >> >> Regards, >> >> Maxim >> >> >> ------------------------------------------------------------------------ >> >> --- src/contrib/gcc/c-ppoutput.c 2004/08/26 14:10:04 1.1 >> +++ src/contrib/gcc/c-ppoutput.c 2004/08/26 14:10:32 >> @@ -292,7 +292,7 @@ >> const cpp_string *str) >> { >> maybe_print_line (print.map, line); >> - fprintf (print.outf, "#ident \"%s\"\n", str->text); >> + fprintf (print.outf, "#ident %s\n", str->text); >> print.line++; >> } >> > > > In the files of the same folder, '#ident' are all in the /* */. I think > fix key_call.c to put #ident into comments makes more sense than change > gcc behaivr. > > Jun Su > > > %grep -r '#ident' /usr/src/lib/libc/* > /usr/src/lib/libc/rpc/clnt_bcast.c:/* #ident "@(#)clnt_bcast.c > 1.18 94/05/03 SMI" */ > /usr/src/lib/libc/rpc/clnt_dg.c:/* #ident "@(#)clnt_dg.c 1.23 > 94/04/22 SMI" */ > /usr/src/lib/libc/rpc/clnt_generic.c:/* #ident "@(#)clnt_generic.c > 1.40 99/04/21 SMI" */ > /usr/src/lib/libc/rpc/key_call.c:#ident "@(#)key_call.c 1.25 94/04/24 > SMI" > /usr/src/lib/libc/rpc/rpc_soc.c:/* #ident "@(#)rpc_soc.c 1.17 > 94/04/24 SMI" */ > /usr/src/lib/libc/rpc/rpcb_clnt.c:/* #ident "@(#)rpcb_clnt.c 1.27 > 94/04/24 SMI" */ > /usr/src/lib/libc/rpc/rpcb_prot.c:/* #ident "@(#)rpcb_prot.c 1.13 > 94/04/24 SMI" */ > /usr/src/lib/libc/rpc/svc_auth.c:/* #ident "@(#)svc_auth.c 1.16 > 94/04/24 SMI" */ > /usr/src/lib/libc/rpc/svc_dg.c:/* #ident "@(#)svc_dg.c 1.17 > 94/04/24 SMI" */ > /usr/src/lib/libc/rpc/svc_generic.c:/* #ident "@(#)svc_generic.c > 1.19 94/04/24 SMI" */ > /usr/src/lib/libc/rpc/svc_raw.c:/* #ident "@(#)svc_raw.c 1.16 > 94/04/24 SMI" */ > > >