From owner-dev-commits-src-all@freebsd.org Mon Jan 11 20:09:18 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A255D4E48E6; Mon, 11 Jan 2021 20:09:18 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp.infotel.ru (corp.infotel.ru [195.170.219.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DF4YB38PZz4nY9; Mon, 11 Jan 2021 20:09:17 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp (corp.infotel.ru [195.170.219.3]) by corp.infotel.ru (Postfix) with ESMTP id 5D0BA182047; Mon, 11 Jan 2021 23:09:16 +0300 (MSK) X-Virus-Scanned: amavisd-new at corp.infotel.ru Received: from corp.infotel.ru ([195.170.219.3]) by corp (corp.infotel.ru [195.170.219.3]) (amavisd-new, port 10024) with ESMTP id IbYFHIbJ-IND; Mon, 11 Jan 2021 23:09:15 +0300 (MSK) Received: from mail.cicgroup.ru (unknown [195.170.219.74]) by corp.infotel.ru (Postfix) with ESMTP id 8D01618203A; Mon, 11 Jan 2021 23:09:15 +0300 (MSK) Received: from mail.cicgroup.ru (localhost [127.0.0.1]) by mail.cicgroup.ru (Postfix) with ESMTP id 165B342211F; Mon, 11 Jan 2021 23:09:14 +0300 (MSK) Received: from mail.cicgroup.ru ([127.0.0.1]) by mail.cicgroup.ru (mail.cicgroup.ru [127.0.0.1]) (amavisd-new, port 10024) with SMTP id Nrakkdhk4-Hz; Mon, 11 Jan 2021 23:09:11 +0300 (MSK) Received: from [192.168.0.30] (gateway [10.0.2.2]) by mail.cicgroup.ru (Postfix) with ESMTPA id 5433A42211C; Mon, 11 Jan 2021 23:09:11 +0300 (MSK) Subject: Re: git: 0f0379fa5581 - main - hid: Add recently imported drivers to NOTES To: John Baldwin , Vladimir Kondratyev , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202101101920.10AJK6rv043957@gitrepo.freebsd.org> From: Vladimir Kondratyev Message-ID: Date: Mon, 11 Jan 2021 23:08:59 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DF4YB38PZz4nY9 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 20:09:18 -0000 On 11.01.2021 21:11, John Baldwin wrote: > On 1/10/21 11:20 AM, Vladimir Kondratyev wrote: >> The branch main has been updated by wulf: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=0f0379fa5581c6b89d22bd041f7443581bac616c >> >> commit 0f0379fa5581c6b89d22bd041f7443581bac616c >> Author: Vladimir Kondratyev >> AuthorDate: 2021-01-09 12:07:19 +0000 >> Commit: Vladimir Kondratyev >> CommitDate: 2021-01-10 19:17:20 +0000 >> >> hid: Add recently imported drivers to NOTES >> >> Reviewed by: hselasky >> Differential revision: https://reviews.freebsd.org/D28060 > > Now that we have entries in NOTES, can we perhaps remove HID_DEBUG > from GENERIC Some part of HID code belonged to USB previously. That is why HID_DEBUG line was inherited from already existing USB_DEBUG in GENERIC. If enabling of USB_DEBUG had no relation to HID, we can delete HID_DEBUG. > along with commented out drivers related to usbhid? Yes we can. I'll add mention about minimal number of devices/options required to enable usbhid reliably to NOTES and delete driver lines from GENERIC. I do not want to delete options USBHID_ENABLED as it is about priority rather than features. May be, it have a sense to change it name to USBHID_DISABLED and enable by default.