From owner-svn-src-all@freebsd.org Sat Mar 30 03:09:16 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5DC6D155F383; Sat, 30 Mar 2019 03:09:16 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B8B7969F14; Sat, 30 Mar 2019 03:09:15 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x2U39Dmh002527; Fri, 29 Mar 2019 20:09:13 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x2U39DtW002526; Fri, 29 Mar 2019 20:09:13 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201903300309.x2U39DtW002526@gndrsh.dnsmgr.net> Subject: Re: svn commit: r345707 - in head: lib/clang lib/libc++ lib/libc++experimental lib/libc++fs lib/libc/tests/stdlib lib/libclang_rt lib/libcxxrt lib/libgcc_eh lib/libomp lib/ofed/libibnetdisc share/mk us... In-Reply-To: <201903291843.x2TIhkMF087562@repo.freebsd.org> To: Enji Cooper Date: Fri, 29 Mar 2019 20:09:13 -0700 (PDT) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: B8B7969F14 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.952,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Mar 2019 03:09:16 -0000 > Author: ngie > Date: Fri Mar 29 18:43:46 2019 > New Revision: 345707 > URL: https://svnweb.freebsd.org/changeset/base/345707 > > Log: > Revert r345706: the third time will be the charm > > When a review is closed via Phabricator it updates the patch attached to the > review. I downloaded the raw patch from Phabricator, applied it, and repeated > my mistake from r345704 by accident mixing content from D19732 and D19738. Which, arguable is a feature or mis feature depending on the point of view. I do not like it when I go to look at someone elses committed code siting a review, as I want to actually see what it was that was committed. You can find the pre-commit diff, but it takes a bit of probling. The upside is you can get both diffs from the same place and diff the diffs :-) > For my own personal sanity, I will try not to mix reviews like this in the > future. :-) Been there, almost did that too. Pre commit last minute svn diff saved me. > MFC after: 1 month > MFC with: r345706 > Approved by: emaste (mentor, implicit) ... -- Rod Grimes rgrimes@freebsd.org