From owner-freebsd-current@FreeBSD.ORG  Wed Jun 20 13:35:31 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id ECCB11065678;
	Wed, 20 Jun 2012 13:35:30 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
	[IPv6:2001:470:1f10:75::2])
	by mx1.freebsd.org (Postfix) with ESMTP id C63D68FC15;
	Wed, 20 Jun 2012 13:35:30 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 2E0D8B97A;
	Wed, 20 Jun 2012 09:35:30 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: current@freebsd.org
Date: Wed, 20 Jun 2012 09:35:27 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p13; KDE/4.5.5; amd64; ; )
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201206200935.27511.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Wed, 20 Jun 2012 09:35:30 -0400 (EDT)
Cc: Bjoern Zeeb <bz@freebsd.org>
Subject: [PATCH] Trim some noise from the daily disk check
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jun 2012 13:35:31 -0000

The daily periodic e-mails for my boxes always include useless output from 
dump -W.  I think the daily e-mail should only do that if the sysadmin is 
actually using dump.  The patch below skips the dump reporting it 
/etc/dumpdates doesn't exist or exists and is an empty file (the latter is 
what you get out-of-the-box):

Index: 400.status-disks
===================================================================
--- 400.status-disks	(revision 237227)
+++ 400.status-disks	(working copy)
@@ -19,13 +19,16 @@ case "$daily_status_disks_enable" in
 	df $daily_status_disks_df_flags && rc=1 || rc=3
 
 	# display which filesystems need backing up
-	if ! [ -f /etc/fstab ]; then
-		export PATH_FSTAB=/dev/null
+	if [ -s /etc/dumpdates ]; then
+		if ! [ -f /etc/fstab ]; then
+			export PATH_FSTAB=/dev/null
+		fi
+
+		echo ""
+		dump W || rc=3
 	fi
+	;;
 
-	echo ""
-	dump W || rc=3;;
-
     *)  rc=0;;
 esac
 
Thoughts?

-- 
John Baldwin