From owner-freebsd-python@freebsd.org Sun Jan 12 04:05:40 2020 Return-Path: Delivered-To: freebsd-python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 538502226CB for ; Sun, 12 Jan 2020 04:05:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 47wNRl64V1z3QQ9 for ; Sun, 12 Jan 2020 04:05:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id BFAFA2226CA; Sun, 12 Jan 2020 04:05:39 +0000 (UTC) Delivered-To: python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BF7092226C9 for ; Sun, 12 Jan 2020 04:05:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47wNRl16tvz3QQ4 for ; Sun, 12 Jan 2020 04:05:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 11627DE47 for ; Sun, 12 Jan 2020 04:05:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 00C45cS2013805 for ; Sun, 12 Jan 2020 04:05:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 00C45cNr013804 for python@FreeBSD.org; Sun, 12 Jan 2020 04:05:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 241966] devel/py-generate: Fix MASTER_SITES, Remote BROKEN Date: Sun, 12 Jan 2020 04:05:39 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: koobs@FreeBSD.org X-Bugzilla-Flags: merge-quarterly? X-Bugzilla-Changed-Fields: see_also Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Jan 2020 04:05:40 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241966 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://github.com/pandas-d | |ev/pandas/issues/949, | |https://github.com/flupke/p | |ypotrace/issues/14, | |https://bugzilla.kernel.org | |/show_bug.cgi?id=3D204231 --- Comment #2 from Kubilay Kocak --- Review items: - Remove PORTREVISION when updating PORTVERSION/DISTVERSION - DISTNAME not required (defaults to PORTNAME-DISTVERSION) - setup.py:version specifies the version is 2.2 (should be 2.8 per PORTVERSION). - Does not require gmake to build: package provides a setup.py utilising setuptools Extension class to build.=20 - Built extension is not stripped: Warning: 'lib/python2.7/site-packages/generate.so' is not stripped consider trying INSTALL_TARGET=3Dinstall-strip or using ${STRIP_CMD} (use $STRIP_CMD} in a post-install: target) - URL [1] declared in setup.py is Forbidden - LICENSE is not defined in port, or setup.py. Some license(s) should be declared so they can be reflected acurately in the port. Could not find lic= ense details on homepage URL or in sources, except the following: - expr.c: from NetBSD (Public Domain) - generate.c: This program may be freely distributed as long as ... (also= in other files) - getline.c # This code may be used on any computer system for ... - USES=3Dpython does not specify a : of supported versions, w= hich allows builds on any (every) Python version. generate fails to import on Py= thon 3: ImportError: /usr/local/lib/python3.7/site-packages/generate.so: Undefin= ed symbol "PyString_FromString" [2][3][4] - Add Trove Classifiers to setup.py to declare what versions are supported - Set setup.py:python_requires to suite - Specify USES=3Dpython: to match above. - A simple test suite / tests for generate would be great for future QA [1] http://www.druid.net/darcy/readme-generate.html [2] https://github.com/pandas-dev/pandas/issues/949 [3] https://github.com/flupke/pypotrace/issues/14 [4] https://bugzilla.kernel.org/show_bug.cgi?id=3D204231 --=20 You are receiving this mail because: You are on the CC list for the bug.=