Date: Sun, 12 Jan 2020 04:05:39 +0000 From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 241966] devel/py-generate: Fix MASTER_SITES, Remote BROKEN Message-ID: <bug-241966-21822-Y2WewduP5K@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-241966-21822@https.bugs.freebsd.org/bugzilla/> References: <bug-241966-21822@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241966 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://github.com/pandas-d | |ev/pandas/issues/949, | |https://github.com/flupke/p | |ypotrace/issues/14, | |https://bugzilla.kernel.org | |/show_bug.cgi?id=3D204231 --- Comment #2 from Kubilay Kocak <koobs@FreeBSD.org> --- Review items: - Remove PORTREVISION when updating PORTVERSION/DISTVERSION - DISTNAME not required (defaults to PORTNAME-DISTVERSION) - setup.py:version specifies the version is 2.2 (should be 2.8 per PORTVERSION). - Does not require gmake to build: package provides a setup.py utilising setuptools Extension class to build.=20 - Built extension is not stripped: Warning: 'lib/python2.7/site-packages/generate.so' is not stripped consider trying INSTALL_TARGET=3Dinstall-strip or using ${STRIP_CMD} (use $STRIP_CMD} in a post-install: target) - URL [1] declared in setup.py is Forbidden - LICENSE is not defined in port, or setup.py. Some license(s) should be declared so they can be reflected acurately in the port. Could not find lic= ense details on homepage URL or in sources, except the following: - expr.c: from NetBSD (Public Domain) - generate.c: This program may be freely distributed as long as ... (also= in other files) - getline.c # This code may be used on any computer system for ... - USES=3Dpython does not specify a :<version-spec> of supported versions, w= hich allows builds on any (every) Python version. generate fails to import on Py= thon 3: ImportError: /usr/local/lib/python3.7/site-packages/generate.so: Undefin= ed symbol "PyString_FromString" [2][3][4] - Add Trove Classifiers to setup.py to declare what versions are supported - Set setup.py:python_requires to suite - Specify USES=3Dpython:<version-spec> to match above. - A simple test suite / tests for generate would be great for future QA [1] http://www.druid.net/darcy/readme-generate.html [2] https://github.com/pandas-dev/pandas/issues/949 [3] https://github.com/flupke/pypotrace/issues/14 [4] https://bugzilla.kernel.org/show_bug.cgi?id=3D204231 --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-241966-21822-Y2WewduP5K>