From owner-svn-src-projects@FreeBSD.ORG Wed Apr 1 19:36:56 2015 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0EC6A2E1; Wed, 1 Apr 2015 19:36:56 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EE5A4E99; Wed, 1 Apr 2015 19:36:55 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.9/8.14.9) with ESMTP id t31Jat19059681; Wed, 1 Apr 2015 19:36:55 GMT (envelope-from sbruno@FreeBSD.org) Received: (from sbruno@localhost) by svn.freebsd.org (8.14.9/8.14.9/Submit) id t31JatXu059680; Wed, 1 Apr 2015 19:36:55 GMT (envelope-from sbruno@FreeBSD.org) Message-Id: <201504011936.t31JatXu059680@svn.freebsd.org> X-Authentication-Warning: svn.freebsd.org: sbruno set sender to sbruno@FreeBSD.org using -f From: Sean Bruno Date: Wed, 1 Apr 2015 19:36:55 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r280965 - projects/em_mq/sys/dev/e1000 X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2015 19:36:56 -0000 Author: sbruno Date: Wed Apr 1 19:36:54 2015 New Revision: 280965 URL: https://svnweb.freebsd.org/changeset/base/280965 Log: Always enqueue work first. If unable to acquire a TXLOCK for this work, schedule a task to come back and do it later. Stolen from igb(4) Modified: projects/em_mq/sys/dev/e1000/if_em.c Modified: projects/em_mq/sys/dev/e1000/if_em.c ============================================================================== --- projects/em_mq/sys/dev/e1000/if_em.c Wed Apr 1 18:57:51 2015 (r280964) +++ projects/em_mq/sys/dev/e1000/if_em.c Wed Apr 1 19:36:54 2015 (r280965) @@ -1002,11 +1002,15 @@ em_mq_start(if_t ifp, struct mbuf *m) txr = &adapter->tx_rings[i]; + error = drbr_enqueue(ifp, txr->br, m); + if (error) + return (error); + if (EM_TX_TRYLOCK(txr)) { error = em_mq_start_locked(ifp, txr, m); EM_TX_UNLOCK(txr); } else - error = drbr_enqueue(ifp, txr->br, m); + taskqueue_enqueue(txr->tq, &txr->tx_task); return (error); } @@ -1027,13 +1031,6 @@ em_mq_start_locked(if_t ifp, struct tx_r return (err); } - enq = 0; - if (m != NULL) { - err = drbr_enqueue(ifp, txr->br, m); - if (err) - return (err); - } - /* Process the queue */ while ((next = drbr_peek(ifp, txr->br)) != NULL) { if ((err = em_xmit(txr, &next)) != 0) {