Date: Thu, 2 Feb 2023 08:49:57 +0100 From: Emmanuel Vadot <manu@bidouilliste.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Stefan =?ISO-8859-1?Q?E=DFer?= <se@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 1e0853ee8403 - main - sys/kbio.h: support Unicode key codes in vt keymap files Message-ID: <20230202084957.631788fd720591beb675acd3@bidouilliste.com> In-Reply-To: <84830C1A-149F-4B05-99DC-1E0B50C8B59A@freebsd.org> References: <202302011630.311GUmt1068106@gitrepo.freebsd.org> <B18FC1EA-29B9-45A8-A666-35F975424256@freebsd.org> <84830C1A-149F-4B05-99DC-1E0B50C8B59A@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2 Feb 2023 07:43:31 +0000 Jessica Clarke <jrtc27@freebsd.org> wrote: > On 1 Feb 2023, at 16:40, Jessica Clarke <jrtc27@FreeBSD.org> wrote: > >=20 > > On 1 Feb 2023, at 16:30, Stefan E=DFer <se@FreeBSD.org> wrote: > >>=20 > >> The branch main has been updated by se: > >>=20 > >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D1e0853ee84031e4131a0b8c= c8737696f199d3d4c > >>=20 > >> commit 1e0853ee84031e4131a0b8cc8737696f199d3d4c > >> Author: Stefan E=DFer <se@FreeBSD.org> > >> AuthorDate: 2023-02-01 16:24:18 +0000 > >> Commit: Stefan E=DFer <se@FreeBSD.org> > >> CommitDate: 2023-02-01 16:24:18 +0000 > >>=20 > >> sys/kbio.h: support Unicode key codes in vt keymap files > >>=20 > >> Some keyboard definitions return Unicode characters that cannot be > >> represented in the 8 bits provided by an u_char. > >>=20 > >> Extend then width of the keycode entries to 16 bits to allow for all > >> keycodes currently defined in share/vt/keymaps/*,kbd. > >>=20 > >> Reported by: yuri@aetern.org > >> MFC after: 3 days > >> --- > >> sys/sys/kbio.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >>=20 > >> diff --git a/sys/sys/kbio.h b/sys/sys/kbio.h > >> index 7f17bda76c51..b0779f5ed114 100644 > >> --- a/sys/sys/kbio.h > >> +++ b/sys/sys/kbio.h > >> @@ -200,7 +200,7 @@ typedef struct okeymap okeymap_t; > >>=20 > >> struct acc_t { > >> u_char accchar; > >> - u_char map[NUM_ACCENTCHARS][2]; > >> + u_short map[NUM_ACCENTCHARS][2]; > >=20 > > This breaks ABI for [GP]IO_DEADKEYMAP. >=20 > Ping. This is important, especially with the MFC after. >=20 > This should be reverted and re-landed with compat IMO. >=20 > Jess Also more importantly it should be discussed. Are we sure that this modification will be enough for all keymaps ? > >> }; > >>=20 > >> struct accentmap { >=20 --=20 Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230202084957.631788fd720591beb675acd3>