From owner-cvs-all Thu Feb 20 13:20: 9 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 18C3037B406; Thu, 20 Feb 2003 13:20:06 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 85C1A43FB1; Thu, 20 Feb 2003 13:20:05 -0800 (PST) (envelope-from mux@freebsd.org) Received: by elvis.mu.org (Postfix, from userid 1920) id 56DBFAE2C6; Thu, 20 Feb 2003 13:20:05 -0800 (PST) Date: Thu, 20 Feb 2003 22:20:05 +0100 From: Maxime Henrion To: Nate Lawson Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c Message-ID: <20030220212005.GP60813@elvis.mu.org> References: <200302191833.h1JIXT2d013173@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Nate Lawson wrote: > On Wed, 19 Feb 2003, Maxime Henrion wrote: > > Modified files: > > sys/pci if_xl.c > > Log: > > Fix panic on sparc64 introduced in my last commit. I really > > wish the busdma APIs were more consistent accross architectures. > > > > We should probably move all the other DMA map creations in > > xl_attach() where we can really handle them failing, since > > xl_init() is void and shouldn't fail. > > Please see my patches for adding/fixing error handling for dmamap_load > (posted to -current). I am going to remove the unnecessary intr alloc > move but otherwise they should be fine. Where are those patches ? I only found http://www.root.org/~nate/freebsd/xl.diff, which is not related to busdma at all. Cheers, Maxime To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message