From owner-freebsd-current Fri Jun 4 6:55:14 1999 Delivered-To: freebsd-current@freebsd.org Received: from mrelay.jrc.it (mrelay.jrc.it [139.191.1.65]) by hub.freebsd.org (Postfix) with ESMTP id 1EF3614DB3 for ; Fri, 4 Jun 1999 06:55:11 -0700 (PDT) (envelope-from nick.hibma@jrc.it) Received: from elect8 (elect8.jrc.it [139.191.71.152]) by mrelay.jrc.it (LMC5692) with SMTP id PAA05925; Fri, 4 Jun 1999 15:43:33 +0200 (MET DST) Date: Fri, 4 Jun 1999 15:43:32 +0200 (MET DST) From: Nick Hibma X-Sender: n_hibma@elect8 Reply-To: Nick Hibma To: Roger Hardiman Cc: Poul-Henning Kamp , current@FreeBSD.ORG Subject: Re: cdevsw_add In-Reply-To: <3757D472.167E@cs.strath.ac.uk> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > I've just fixed the bt848 driver (bktr) where the > cdevsw_add() was accidentally added to the BSDI bktr_probe() > and not the FreeBSD bktr_probe. > > Although Bruce and Nick said this really belongs, in the _attatch() > function, I've kept it in the _probe() function for consistency > with all the other drivers. Hm, I think this a bad choice. Which are 'all the other drivers'? The probe should really be as thin as possible to avoid unnecessary delays when probing in a kernel, like GENERIC, with a lot of device drivers compiled in. Nick -- ISIS/STA, T.P.270, Joint Research Centre, 21020 Ispra, Italy To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message