From owner-freebsd-ports  Fri Nov  1 17: 0: 6 2002
Delivered-To: freebsd-ports@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2165937B401
	for <freebsd-ports@hub.freebsd.org>; Fri,  1 Nov 2002 17:00:03 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6D29E43E75
	for <freebsd-ports@hub.freebsd.org>; Fri,  1 Nov 2002 17:00:02 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id gA2102x3028627
	for <freebsd-ports@freefall.freebsd.org>; Fri, 1 Nov 2002 17:00:02 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.6/8.12.6/Submit) id gA2102Lj028626;
	Fri, 1 Nov 2002 17:00:02 -0800 (PST)
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8C7E937B401
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  1 Nov 2002 16:54:02 -0800 (PST)
Received: from harrier.mail.pas.earthlink.net (harrier.mail.pas.earthlink.net [207.217.120.12])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 13FD243E77
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  1 Nov 2002 16:53:57 -0800 (PST)
	(envelope-from parv_fm@mailsent.net)
Received: from sdn-ap-015dcwashp0190.dialsprint.net ([63.188.144.190] helo=moo.holy.cow)
	by harrier.mail.pas.earthlink.net with esmtp (Exim 3.33 #1)
	id 187mXv-0003J1-00
	for FreeBSD-gnats-submit@freebsd.org; Fri, 01 Nov 2002 16:53:52 -0800
Received: by moo.holy.cow (Postfix, from userid 1001)
	id 87FE6B967; Fri,  1 Nov 2002 19:56:32 -0500 (EST)
Message-Id: <20021102005632.87FE6B967@moo.holy.cow>
Date: Fri,  1 Nov 2002 19:56:32 -0500 (EST)
From: parv <parv_fm@emailgroups.net>
To: FreeBSD-gnats-submit@FreeBSD.org
X-Send-Pr-Version: 3.113
Subject: ports/44820: x11-wm/fvwm2-devel - PATCH to take care of a nasty pager problem
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org


>Number:         44820
>Category:       ports
>Synopsis:       x11-wm/fvwm2-devel - PATCH to take care of a nasty pager problem
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Nov 01 17:00:01 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     parv
>Release:        FreeBSD 4.7-RELEASE i386
>Organization:
>Environment:
System: FreeBSD moo.holy.cow 4.7-RELEASE

fvwm 2.5.4

>Description:

with the following minimum custom configuration file, FvwmPager uses
near 100% CPU...
           
  AddToFunc StartFunction
  + I Module FvwmPager * *
      
  DeskTopSize  2x2
        
  DestroyModuleConfig FvwmPager: *
  *FvwmPager: NoSeparators


...for more details see...

  http://www.hpc.uh.edu/fvwm/archive/0211/msg00000.html


>How-To-Repeat:

use fvwm 2.5.4 w/ above config file & see CPU use jump to 100%


>Fix:

below is the patch generated from differences in x_pager.c versions
in fvwm cvs & freebsd fvwm 2.5.4 port...


--- modules/FvwmPager/x_pager.c.old	Thu Oct 24 00:46:59 2002
+++ modules/FvwmPager/x_pager.c	Fri Nov  1 19:26:11 2002
@@ -1630,8 +1630,8 @@
 				XDrawLine(
 					dpy,Desks[desk].w,Desks[desk].DashedGC,
 					x1,y1,x1,y2);
-				x += Scr.MyDisplayWidth;
 			}
+			x += Scr.MyDisplayWidth;
 		}
 		y = Scr.MyDisplayHeight;
 		x1 = 0;
@@ -1640,9 +1640,11 @@
 		{
 			y1 = (y * desk_h) / Scr.VHeight;
 			if (!use_no_separators)
+			{
 				XDrawLine(
 					dpy,Desks[desk].w,Desks[desk].DashedGC,
 					x1,y1,x2,y1);
+			}
 			y += Scr.MyDisplayHeight;
 		}
 	}


>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message