From owner-freebsd-current@FreeBSD.ORG Tue Apr 14 19:02:20 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9E327106566B for ; Tue, 14 Apr 2009 19:02:20 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.30]) by mx1.freebsd.org (Postfix) with ESMTP id 4F35F8FC15 for ; Tue, 14 Apr 2009 19:02:20 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: by yx-out-2324.google.com with SMTP id 8so1607530yxm.13 for ; Tue, 14 Apr 2009 12:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=0WDKdl6L06Vi48CU8e1TgStYz7AnDMmWfo6/0odypzQ=; b=gwW/aanknDmzo0sb/fQmIrdvO5bPV9BV4doqI+oZFckhgqqaFe4zxfXqf1fRi7JqON mP45r8HM/xxVFHJJmjvpvTCPqVWzzV2B02KBM1wceE0nMCtYfkEBkQQHmqDHzds+cRAe wEBr8yVUlG9SYPMZlYCfI++m+A9Sc23H5gSFA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=pTa+o2RdsbjVFYSiqXnTqZL0pCRTdtPZwHCt3N2PDPrPom8HjWoko5I9KpMM+NHmf9 6rjDVXsiI2tWZpo4A0bMpMC7upYDUzC8ClpZXAs3kQYaXvypw34KseAgVtaRNWyEovsL hdKcMsYOBGGnd3yDXGSNlkYUaZxzMvn2FRmZI= MIME-Version: 1.0 Sender: maksim.yevmenkin@gmail.com Received: by 10.90.84.2 with SMTP id h2mr10117103agb.72.1239735738717; Tue, 14 Apr 2009 12:02:18 -0700 (PDT) In-Reply-To: <20090414180020.34b97378@fabiankeil.de> References: <200904082052.n38KqU9p075633@svn.freebsd.org> <20090412170335.5a8a3169@fabiankeil.de> <20090414180020.34b97378@fabiankeil.de> Date: Tue, 14 Apr 2009 12:02:18 -0700 X-Google-Sender-Auth: fb2d0742ae798941 Message-ID: From: Maksim Yevmenkin To: Fabian Keil Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org Subject: Re: svn commit: r190857 - head/sys/dev/kbdmux X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2009 19:02:21 -0000 On Tue, Apr 14, 2009 at 9:00 AM, Fabian Keil wrote: > Maksim Yevmenkin wrote: > >> On Sun, Apr 12, 2009 at 8:03 AM, Fabian Keil >> wrote: >> > Maksim Yevmenkin wrote: >> > >> >> Author: emax >> >> Date: Wed Apr 8 20:52:30 2009 >> >> New Revision: 190857 >> >> URL: http://svn.freebsd.org/changeset/base/190857 >> >> >> >> Log: >> >> Undo SVN rev 183283 >> >> >> >> Do not use Giant for kbdmux(4) locking. This is wrong and apparently >> >> causing more problems than it solves. This will re-open the issue >> >> where interrupt handlers may race with kbdmux(4) in polling mode. >> >> Typical symptoms include (but not limited to) duplicated and/or >> >> missing characters when low level console functions (such as gets) >> >> are used while interrupts are enabled (for example geli password >> >> prompt, mountroot prompt etc.) >> >> >> >> MFC after: 3 days >> >> >> >> Modified: >> >> head/sys/dev/kbdmux/kbdmux.c > > [...] > >> > Not even enabling the "visible characters" option helps >> > because obviously backspace is broken too. >> >> if you do not need kbdmix(4) you might just want to disable it on your >> system. i think it should help with your particular problem. > > Removing kbdmux from the kernel does indeed work around the problem. > >> > Before theses locks were introduces I worked around the problem >> > with this gets() hack (which forced me to reduce the key entropy): >> > http://www.fabiankeil.de/sourcecode/freebsd/gets-no-duplicates.diff >> > and now I will simply revert your commit locally, but I assume I'm >> > not the only geli user who prefers to be able to boot the system >> > without local patches. >> >> if your primary keyboard is atkbd(4), you might want to try the >> following patch. it is completely untested (i did not even compile >> it), so be warned ... > > It compiles alright but once the system is running the keyboard > no longer works at all. I tested the patch with kbdmux already > disabled, but I assume it doesn't make a difference. hmmm, interesting, i do not see this. atkbd(4) is working just fine with and without kbdmux(4) for me in sinlge user, ddb and multiuser. > Anyway, I don't need kbdmux, so having to remove it is no problem. > Thanks a lot. ok thanks max