Date: Mon, 19 Jul 2004 06:39:17 -0400 From: Brian Fundakowski Feldman <green@FreeBSD.org> To: Alan Cox <alc@cs.rice.edu> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys malloc.h src/sys/kern kern_malloc.c src/sys/vm vm_contig.c vm_page.h Message-ID: <20040719103917.GD1038@green.homeunix.org> In-Reply-To: <20040719071147.GS18577@cs.rice.edu> References: <200407190621.i6J6LRWJ019976@repoman.freebsd.org> <40FB718B.7080206@samsco.org> <20040719071147.GS18577@cs.rice.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 19, 2004 at 02:11:47AM -0500, Alan Cox wrote: > On Mon, Jul 19, 2004 at 01:00:27AM -0600, Scott Long wrote: > > This is a pretty darn big change to something that is so vital to so > > many drivers (not including busdma, which means that this touches nearly > > every driver). Who reviewed this? Was it discussed on a public mailing > > list? What kind of testing was done for it? If you can't answer these > > questions then I'm not terribly thrilled. > > > > I reviewed an earlier version of this and gave Brian some feedback. > > It is important to note that he added the new implementation side-by-side > with the old. By default, the old implementation is still used. So, I > wouldn't be too concerned. Aye, I didn't feel totally comfortable saying "Reviewed by:" since that was a while ago, but between alc and hmp who has been overhauling the contigmalloc() implementation in DFBSD there wasn't any concern that I know I hadn't addressed (and Dillon ignored my solicitation). -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040719103917.GD1038>