From owner-svn-src-head@freebsd.org Sun Aug 12 22:05:24 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B1B2107DFEF; Sun, 12 Aug 2018 22:05:24 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f175.google.com (mail-io0-f175.google.com [209.85.223.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 272B77BF37; Sun, 12 Aug 2018 22:05:24 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f175.google.com with SMTP id l7-v6so8850801iok.6; Sun, 12 Aug 2018 15:05:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=iqyXkiNth+5yU2w/lV/IBOMmbKA4Sp1VL9C+Dn8agDI=; b=bSoUw7nyvscN+tkc9HuFwPSXN4lNPG9ESCcNuWEZtWPzAbLWumS3G+2HBXLQ4Tv5o2 xlKpYIaYOkb6fHiyUcVTRjwKJk7XvDjax8bIz+5TXQ38mdDRZ4vnMmJ3KXxre6LJsLOz AOAjicdiX8DHCtCF3XRf7vT8gqy4lp/SEQ3klemc8EoTeQkiRzIVbZpp7M8XqzLE0fks GC0knjZDX7jyOZovbJ6vTcJ0FEDevLHkAmMdPpb9HEl/1g/tgR3ZGBsKG29MWlnR3VLl +o2VHCduMvbY4SYspj4YojlpCmSzZB55YtXdvi2QGeUwmS9jLPLENPOdVxnBqejlhiM/ /SMg== X-Gm-Message-State: AOUpUlFavGkAwYpfA8IO8sHbPH45TGsN5b2ekf1v1wBHM6c/QsOnAPBj WVrb1zo5h+tdllIphQ15KKD6/qH3 X-Google-Smtp-Source: AA+uWPyPxbe8MEgFzG4BHnW/tmo5I+OAJZ4GkR3n+7bwul+e4FY2royudTPXDB6AnfpuEj3GncYCvg== X-Received: by 2002:a6b:a508:: with SMTP id o8-v6mr11824852ioe.41.1534107869470; Sun, 12 Aug 2018 14:04:29 -0700 (PDT) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com. [209.85.223.178]) by smtp.gmail.com with ESMTPSA id l13-v6sm5319975itb.43.2018.08.12.14.04.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Aug 2018 14:04:28 -0700 (PDT) Received: by mail-io0-f178.google.com with SMTP id y10-v6so12582150ioa.10; Sun, 12 Aug 2018 14:04:28 -0700 (PDT) X-Received: by 2002:a6b:b0c5:: with SMTP id z188-v6mr12414476ioe.220.1534107868784; Sun, 12 Aug 2018 14:04:28 -0700 (PDT) MIME-Version: 1.0 References: <201808092153.w79LrWEZ097986@repo.freebsd.org> In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Thu, 9 Aug 2018 19:41:32 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r337554 - in head/sys/cam: . ata nvme scsi To: Scott Long Cc: Conrad Meyer , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Aug 2018 22:05:24 -0000 I had two functional changes in mind for after this part (which I hoped would be non controversial) that you would be included on the review. Markj pointed me at the related D15592. I=E2=80=99m not sure that approach= was the correct one and hope to continue discussion there. Once that=E2=80=99s rea= ched consensus, I may need to revisit my subsequent change. If it ends up that ultimately this particular patch isn=E2=80=99t used, backing it out is triv= ial. Until then, it=E2=80=99s pretty harmless. Thanks, Conrad On Thu, Aug 9, 2018 at 2:56 PM Scott Long wrote: > > > > On Aug 9, 2018, at 3:53 PM, Conrad Meyer wrote: > > > > Author: cem > > Date: Thu Aug 9 21:53:32 2018 > > New Revision: 337554 > > URL: https://svnweb.freebsd.org/changeset/base/337554 > > > > Log: > > cam(4): Add an xpt-neutral flag indicating a valid panic CCB > > > > No functional change. > > > > Note that this change is careful to set the CCB header xflags after > > foo_fill_bar() routines, which generally zero existing flags. An > earlier > > version of this patch mistakenly set the flag before the fill routines= . > > > > Submitted by: Scott Ferris , jhibbits@ > > Reviewed by: bdrewery@, markj@, and non-committer FreeBSD contributor > Anton Rang > > Sponsored by: Dell EMC Isilon > > What=E2=80=99s the purpose of this flag? I see it gets set in plenty of = places, > but never checked. > > Scott > >