From owner-freebsd-hackers  Sun Apr  7  6:27:26 2002
Delivered-To: freebsd-hackers@freebsd.org
Received: from mailgate.rz.uni-karlsruhe.de (mailgate.rz.uni-karlsruhe.de [129.13.64.97])
	by hub.freebsd.org (Postfix) with ESMTP id 9DD7037B434
	for <freebsd-hackers@freebsd.org>; Sun,  7 Apr 2002 06:27:11 -0700 (PDT)
Received: from rzstud1.rz.uni-karlsruhe.de (rzstud1.rz.uni-karlsruhe.de [193.196.41.33])
	by mailgate.rz.uni-karlsruhe.de with esmtp (Exim 3.33 #1)
	id 16uChI-0001Vc-00; Sun, 07 Apr 2002 15:27:08 +0200
Received: from un1i by rzstud1.rz.uni-karlsruhe.de with local (Exim 3.33 #1)
	id 16uChR-00069v-00; Sun, 07 Apr 2002 15:27:17 +0200
Date: Sun, 7 Apr 2002 15:27:16 +0200
From: Philipp Mergenthaler <un1i@rz.uni-karlsruhe.de>
To: =?iso-8859-1?Q?S=F8ren?= Schmidt <sos@freebsd.dk>
Cc: freebsd-hackers@FreeBSD.ORG, maxim@macomnet.ru
Subject: Re: cdcontrol(1) speed command
Message-ID: <20020407132716.GA3437@rz.uni-karlsruhe.de>
References: <E16tTvt-0002NJ-00@rzstud1.rz.uni-karlsruhe.de> <200204051431.g35EV5b33064@freebsd.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <200204051431.g35EV5b33064@freebsd.dk>
User-Agent: Mutt/1.3.27i
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

On Fri, Apr 05, 2002 at 04:31:04PM +0200, S=F8ren Schmidt wrote:
> It seems Philipp Mergenthaler wrote:
> > > @@ -24,6 +24,7 @@
> > >  #endif /* not lint */
> >=20
> > >  #include <sys/cdio.h>
> > > +#include <sys/cdrio.h>
> >=20
> > J=F6rg Wunsch commented that adding "include <sys/cdrio.h>" would be
> > wrong and that this ioctl should be moved to sys/cdio.h instead.
> > (I guess then it should be renamed to CDIOCREADSPEED, too.)
> > This would then have to be changed in src/sys/dev/ata/atapi-cd.c, too.
>=20
> Hmm, then the functionality should be added to the SCSI CD driver
> first, until then its only for ATAPI CDROM's, and should stay
> where it is, to not break binary compatibility..

Ok, kern/36845 adds this to the SCSI driver.  I don't have a SCSI
CD drive to test with, but it works with my ATAPI drive + ATAPICAM,
FWIW :-).

What's the best way to proceed?  Should Maxim commit the change to
cdcontrol as it is and i'll wait until kern/36845 is committed
and then send-pr a patch which moves this ioctl from cdio.h to cdrio.h
and renames it? (And also in atapi-cd.c, scsi-cd.c and cdcontrol.c)

Thanks, Philipp

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message