From owner-dev-commits-src-all@freebsd.org Mon May 31 19:50:29 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 46D0864E2ED; Mon, 31 May 2021 19:50:29 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fv5Vs1HDTz4pJD; Mon, 31 May 2021 19:50:29 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oo1-f50.google.com with SMTP id v13-20020a4aa40d0000b02902052145a469so2996791ool.3; Mon, 31 May 2021 12:50:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kcjpRp0bo3X9nlu0sHyQGtu1uGBQJnuipczdjAT7dHE=; b=qm4lSpElzYIZiPMevoBeBf8n5Ep95kIDw3DHIqBIOVURV+fXEl/DdhW8FWrBNQLAYY 2myR+kZCtHKyewKsVFwiB8HNgqKryVqvGRnTEDyEEuSqB9pF5a3PfOz/l1tgyBLQ0uTe d+niyLYumqMO3TxQvQIDOD41A7hkAJQzLbGGDLzw64UC3lbHaQ48P44DBvYVtAn3KNWs bdlUZnKu7tVmGnp5Wh5Im203Av8YqppMRI3UpnycwrW7aVPqO51A/T6zhxDgO0VHLufV hl44AiEn6Y1q4iKC04BQrtNslUUsHU2jUdqVVl49YHHnquiFy1TH71SdtMRVTJmUsYbM qkBw== X-Gm-Message-State: AOAM532kzqHWbg0RJZGZz8nZUy9tX0zDWrekY5w0Ca0c4Sslp+puWGjd k+/o9Sti40feC3T28QJIfnNgnuG6PTLo+m8CRZWNZKOrITkjfQ== X-Google-Smtp-Source: ABdhPJzqckGyq1l6fyzUI6bOeldKNeVSWCDK3GN131C9QfjF+RFcsNmt7j+bUswXUFoWMV9S0yw2TUOr39zrGLhhEY0= X-Received: by 2002:a4a:7506:: with SMTP id j6mr17545487ooc.79.1622490627808; Mon, 31 May 2021 12:50:27 -0700 (PDT) MIME-Version: 1.0 References: <202105302249.14UMnbcl094541@gitrepo.freebsd.org> <0434E9D2-B0AA-4B5E-942A-A393A83DFFD1@freebsd.org> In-Reply-To: <0434E9D2-B0AA-4B5E-942A-A393A83DFFD1@freebsd.org> From: Alan Somers Date: Mon, 31 May 2021 13:50:16 -0600 Message-ID: Subject: Re: git: 5a20c351ea45 - main - [skip ci] add a CODEOWNERS file To: Jessica Clarke Cc: Warner Losh , Ed Maste , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4Fv5Vs1HDTz4pJD X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 May 2021 19:50:29 -0000 On Mon, May 31, 2021 at 1:39 PM Jessica Clarke wrote: > On 31 May 2021, at 20:37, Warner Losh wrote: > > > > > > > > On Mon, May 31, 2021 at 1:21 PM Jessica Clarke > wrote: > > On 31 May 2021, at 20:16, Warner Losh wrote: > > > > > > > > > > > > On Mon, May 31, 2021, 1:11 PM Ed Maste wrote: > > > On Mon, 31 May 2021 at 11:51, Alan Somers wrote= : > > > > > > > >> > > > >> I think this file isn't the right place for (another copy of) this > > > >> text; perhaps the CODEOWNERS file should just reference the > top-level > > > >> MAINTAINERS? > > > > > > > > Except that CODEOWNERS is in a format that tools know how to parse. > If anything, MAINTAINERS should be a symlink to CODEOWNERS. > > > > > > At least the file's location and user IDs suggest that it is specific > > > to GitHub; in any case I don't really care which one points to which. > > > I hope we can agree though that we don't really want two different > > > files representing code ownership in different ways that both > > > independently refer to a third mechanism for recording code ownership > > > that's external to the source tree? > > > > > > It also works on gitlab, FWIW. The format is standard. Bummer we can'= t > generate it based on where it is published=E2=80=A6 > > > > We could conceivably have a CODEOWNERS.master from which the others can > be generated via `make codeowners` whenever someone edits it. Whether > that=E2=80=99s worth the hassle of implementing though for a file that sh= ouldn=E2=80=99t > regularly be changing is unclear. > > > > Doing that's trivial... However, it would mean that the automatic > flagging that this file's presence gives wouldn't work... But then again, > there's no issues or pull requests at the gitlab mirror, so at the moment > it's a bit of a moot point. > > A hypothetical .gitlab/CODEOWNERS would be checked in as a generated file= , > if that was unclear. Otherwise I=E2=80=99m not sure I understand your fir= st point? > > Jess > There's no need to generate anything. Both github and gitlab support a CODEOWNERS file in the project's root. Let's just move it there. We can delete the old MAINTAINERS, too, once all of its entries have been converted.