From owner-freebsd-ports@FreeBSD.ORG  Sun Aug 20 09:08:44 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: ports@FreeBSD.org
Delivered-To: freebsd-ports@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 48A1416A4DF
	for <ports@FreeBSD.org>; Sun, 20 Aug 2006 09:08:44 +0000 (UTC)
	(envelope-from infofarmer@gmail.com)
Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.183])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C7B9F43D7C
	for <ports@FreeBSD.org>; Sun, 20 Aug 2006 09:08:42 +0000 (GMT)
	(envelope-from infofarmer@gmail.com)
Received: by py-out-1112.google.com with SMTP id o67so1905447pye
	for <ports@FreeBSD.org>; Sun, 20 Aug 2006 02:08:42 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
	b=h0vF8aoFjmSlG5hg0nVUDm4eh2li79hUKsXPDbvXhKOoNRGL1rswtKapXMsH5fE7F29VnuC9rlWHLa51cHCqozhm73ZkKxulSht67C4W1s17WmOUsD4bWhYLy5RPDrHDTPNrxvMrTgntRGwJqjIaEJvURehDqYPJWfdPKhvdHcU=
Received: by 10.35.63.2 with SMTP id q2mr10347656pyk;
	Sun, 20 Aug 2006 02:08:42 -0700 (PDT)
Received: by 10.35.105.10 with HTTP; Sun, 20 Aug 2006 02:08:42 -0700 (PDT)
Message-ID: <cb5206420608200208j4c27177dh3b8d004e8213de4f@mail.gmail.com>
Date: Sun, 20 Aug 2006 13:08:42 +0400
From: "Andrew Pantyukhin" <infofarmer@FreeBSD.org>
Sender: infofarmer@gmail.com
To: "Doug Barton" <dougb@FreeBSD.org>
In-Reply-To: <cb5206420608200158q22edef00jd53e646439207149@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <cb5206420608160931q65adc8fft6084e7f498b403f5@mail.gmail.com>
	<cb5206420608190944o5c07dbefwfdf50586ae23ef5a@mail.gmail.com>
	<44E81C12.9050306@FreeBSD.org>
	<cb5206420608200158q22edef00jd53e646439207149@mail.gmail.com>
X-Google-Sender-Auth: 46db4dda57f2845d
Cc: FreeBSD Ports <ports@FreeBSD.org>, portmgr@FreeBSD.org
Subject: Re: Enforcing "DIST_SUBDIR/DISTFILE" uniqueness
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Aug 2006 09:08:44 -0000

On 8/20/06, Andrew Pantyukhin <infofarmer@freebsd.org> wrote:
> On 8/20/06, Doug Barton <dougb@freebsd.org> wrote:
> > OTOH, your solution would break the logic that portmaster (and I believe
> > portupgrade also) uses to detect and delete stale distfiles.
>
> AFAICT portmaster's logic still misses the case when
> DIST_SUBDIR has changed for whatever reason.

Oh, now that I've had another look at portmaster's logic it
doesn't makes sense at all. What if distfiles of different
ports have similar %[-_]* names? What if different ports
require the same distfile of different versions? What if
distname changed radically? You can't make such broad
assumptions about distfile patterns. You should probably
do it the same way portsclean -D does - i.e. to check
"dist_subdir/distfile" against distinfo files of all installed
ports or all ports, whichever a user prefers.