From owner-svn-ports-head@FreeBSD.ORG Wed Oct 8 01:03:01 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 217A94DD for ; Wed, 8 Oct 2014 01:03:01 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 02961C0B for ; Wed, 8 Oct 2014 01:03:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id s98130dP067851 for ; Wed, 8 Oct 2014 01:03:00 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id s98130ul067844 for svn-ports-head@freebsd.org; Wed, 8 Oct 2014 01:03:00 GMT (envelope-from bdrewery) Received: (qmail 16485 invoked from network); 7 Oct 2014 20:02:59 -0500 Received: from unknown (HELO ?10.10.0.24?) (freebsd@shatow.net@10.10.0.24) by sweb.xzibition.com with ESMTPA; 7 Oct 2014 20:02:59 -0500 Message-ID: <54348D3C.6080600@FreeBSD.org> Date: Tue, 07 Oct 2014 20:02:52 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Matthias Andree , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r370411 - head/sysutils/e2fsprogs References: <201410072343.s97Nhkgo093413@svn.freebsd.org> <54348726.1080004@FreeBSD.org> In-Reply-To: <54348726.1080004@FreeBSD.org> OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KMkS2UgVxHlI1seFeP5UcH7i0aI9IW4hg" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Oct 2014 01:03:01 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KMkS2UgVxHlI1seFeP5UcH7i0aI9IW4hg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/7/2014 7:36 PM, Bryan Drewery wrote: > On 10/7/2014 6:43 PM, Matthias Andree wrote: >> Author: mandree >> Date: Tue Oct 7 23:43:46 2014 >> New Revision: 370411 >> URL: https://svnweb.freebsd.org/changeset/ports/370411 >> QAT: https://qat.redports.org/buildarchive/r370411/ >> >> Log: >> Mark broken everywhere, upstream bug (already reported). >> To avoid PORTEPOCH/rollback-and-forth-again, let's give upstream a f= ew >> days for a fix before rolling back to 1.42.10. >=20 > This is horrible. We're providing no packages for any branch now to > avoid bumping a metadata counter? >=20 >=20 Unfortunately poudriere does not care that this is BROKEN. It reads PKGVERSION, sees it is newer, deletes the old package, then finally finds it should IGNORE it. A bug in poudriere sure. >=20 >> =20 >> Added a comment to Makefile: >> =20 >> # Regression that apparently causes use-after-free in=C2=B7 >> # http://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/commit/?h=3Dmaint= &id=3D47fee2ef6a23ae06f680336ffde57caa64604a4c >> # and can be reproduced under MALLOC_OPTIONS=3DJ regime on 9.3-amd64= , or >> # alternatively confirmed with valgrind, was reported upstream. >> # >> # Let's wait until 2014-10-15 whether upstream provides a fix, >> # else we'll bump PORTEPOCH and roll back to 1.42.10; >> # 1.42.11 is also faulty. >> >> Modified: >> head/sysutils/e2fsprogs/Makefile >> >> Modified: head/sysutils/e2fsprogs/Makefile >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/sysutils/e2fsprogs/Makefile Tue Oct 7 23:26:28 2014 (r370410= ) >> +++ head/sysutils/e2fsprogs/Makefile Tue Oct 7 23:43:46 2014 (r370411= ) >> @@ -53,10 +53,6 @@ USES+=3D gettext iconv:build >> =20 >> .include >> =20 >> -.if ${OSVERSION} >=3D 1100000 >> -BROKEN=3D Segfaults and miscalculations observed on redports >> -.endif >> - >> .if ${PORT_OPTIONS:MNLS} >> PLIST_SUB=3D NLS=3D"" >> . if empty(ICONV_LIB) >> @@ -84,6 +80,16 @@ post-patch:: >> .endfor >> =20 >> .if ${MASTERDIR} =3D=3D ${.CURDIR} >> +# Regression that apparently causes use-after-free in=20 >> +# http://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/commit/?h=3Dmaint&= id=3D47fee2ef6a23ae06f680336ffde57caa64604a4c >> +# and can be reproduced under MALLOC_OPTIONS=3DJ regime on 9.3-amd64,= or >> +# alternatively confirmed with valgrind, was reported upstream. >> +# >> +# Let's wait until 2014-10-15 whether upstream provides a fix, >> +# else we'll bump PORTEPOCH and roll back to 1.42.10; >> +# 1.42.11 is also faulty. >> +BROKEN=3D Use-after-free bug, see ${.CURDIR}/Makefile comments for d= etails >> + >> pre-build: >> # fix up Makefile ordering for parallel builds >> cd ${WRKSRC}/lib/et && ${DO_MAKE_BUILD} compile_et >> >=20 >=20 --=20 Regards, Bryan Drewery --KMkS2UgVxHlI1seFeP5UcH7i0aI9IW4hg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJUNI08AAoJEDXXcbtuRpfPaskIALnAA19giIS846zisyYKIDwt OLb8h76kpNyG2TbNJMpVRZsFzJ7QkecssAg//mHD4GL+tTqtAFC6mXaG3YZUTcXg qpUC/1Cgb6O44OT2UjE0MFbh7T+VVrMfW+xER1QnkfTEAqDpXLsCAURRaOijCVor eCTAP+/TljiQQtyKUXMCtNhTxjoKqZ2rwZYHtqcInLzfUeKSFIHaUAm3miH3F3Z0 8F9AR+QBm2TRiqaKBEBv5gFWqgBRafRo0E9PG28zAV+f9TT2rS0Sw9Xg97DvkYpX hYaAY1X6T6nMwBbR/bNDulPnCnsqqPkpA1pd0sAu+8H79gmWIIvjOaXADGKJR3s= =+rtO -----END PGP SIGNATURE----- --KMkS2UgVxHlI1seFeP5UcH7i0aI9IW4hg--