From owner-svn-src-projects@FreeBSD.ORG  Tue Mar  2 13:00:51 2010
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C2764106573E;
	Tue,  2 Mar 2010 13:00:51 +0000 (UTC)
	(envelope-from bms@incunabulum.net)
Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com
	[66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id 8D1338FC1F;
	Tue,  2 Mar 2010 13:00:51 +0000 (UTC)
Received: from compute1.internal (compute1 [10.202.2.41])
	by gateway1.messagingengine.com (Postfix) with ESMTP id 395E0E2C73;
	Tue,  2 Mar 2010 07:43:03 -0500 (EST)
Received: from heartbeat1.messagingengine.com ([10.202.2.160])
	by compute1.internal (MEProxy); Tue, 02 Mar 2010 07:43:03 -0500
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com;
	h=message-id:date:from:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding;
	s=smtpout; bh=gPq84zwdAHULU3SxsSkgbRKqjFU=;
	b=KHHRlwsRnF6+BqXS+6sFjHFkm5LmqWakAk/0UB/iWoo3R9mTAqQfWo9nYgEMl8csZ1YxZBRNRsrKlRGVTAolmLo/sYg8Bq8duYLS1/RElI6NrWonWVJ8vwX3mBLqNQvFvr2LzQ3+yTWfHj0vsS24uFTZTSxHTTD9TVtsU97xMCY=
X-Sasl-enc: PDb0DbE5zvYDorJu8YOJmt4TgPxNzGGymPcPMRQdYxz2 1267533783
Received: from anglepoise.lon.incunabulum.net
	(cpc2-dals7-0-0-cust253.hari.cable.virginmedia.com [82.35.112.254])
	by mail.messagingengine.com (Postfix) with ESMTPSA id 927A44C850D;
	Tue,  2 Mar 2010 07:43:02 -0500 (EST)
Message-ID: <4B8D07D3.6000303@incunabulum.net>
Date: Tue, 02 Mar 2010 12:42:59 +0000
From: Bruce Simpson <bms@incunabulum.net>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.1.8) Gecko/20100228 Thunderbird/3.0.2
MIME-Version: 1.0
To: Roman Divacky <rdivacky@freebsd.org>
References: <201003012130.o21LUB0I022574@svn.freebsd.org>
	<201003011744.45410.jhb@freebsd.org>
	<20100302082214.GA24947@freebsd.org>
In-Reply-To: <20100302082214.GA24947@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org,
	John Baldwin <jhb@freebsd.org>
Subject: Re: svn commit: r204537 - in projects/clangbsd/contrib/libstdc++:
 include/ext src
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
	tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
	<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Mar 2010 13:00:51 -0000

On 03/02/10 08:22, Roman Divacky wrote:
> <disclaimer>
> I am not a C++ expert but these changes were suggested by a member
> of C++ committee. ie. I trust them :)
>>> @@ -382,7 +382,7 @@ _GLIBCXX_BEGIN_NAMESPACE(__gnu_cxx)
>>>   	  {
>>>   	    _Rope_RopeLeaf<_CharT, _Alloc>* __l
>>>   	      = (_Rope_RopeLeaf<_CharT, _Alloc>*)this;
>>> -	    __l->_Rope_RopeLeaf<_CharT, _Alloc>::~_Rope_RopeLeaf();
>>> +	    __l->template _Rope_RopeLeaf<_CharT, _Alloc>::~_Rope_RopeLeaf();
>>>   	    _L_deallocate(__l, 1);
>>>   	    break;
>>>   	  }
>>>        
>> Hmm, this hurts my brain to have 'template ' in the middle of a dereference.
>> I also don't see why it should be needed.
>>      
> C++ seems to work this way... it's ugly yes, but correct
>    

+1. You do need to qualify the use of templates in situations like this.