From nobody Sun Sep 14 17:47:34 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cPwbq27SXz67Cjk; Sun, 14 Sep 2025 17:47:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cPwbp6l5wz3cdZ; Sun, 14 Sep 2025 17:47:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757872054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EoG7OIbAdEfXh4/Iaw/s/M6Um4lBYlzMo5l/oNaWyOM=; b=AFUBL/ECb81v/MAz5i+6gSOnphpo/dwL9o7sdyKWx6h+7HrylRW/2eo636A8NMc2Qj7sAP GS1XsuAmec9+Um01ky4R44pzFn8z6ymqe4q50saFB6JaaTzZ/ZtCnl74V2LRDCh0fXa6Kt jMd//msJcYoKsllSzQhGeU8qymu21C95IOKBDx3QMxKGNmFR8LQDDf38fCWuHPMYrmzrru GXyWz0cZQg6dZsw2ILRNc4yTjm9TbND3TF4Q2vDjWzmWCKFs+ROYqxrpcEjRA4q8I/bAaj FyImy3/glxcZnN5UHAsBwGWtDOhsmNuMP6eqWbVNKiEkbdL6ln5gss+jLoe4Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757872055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EoG7OIbAdEfXh4/Iaw/s/M6Um4lBYlzMo5l/oNaWyOM=; b=ZTS0luDKo1hpne9s0GWIfCRNTrmDVv068kMV85/ne/Vx4cRtap7tlWceQV847OmY0wTjO3 cLX/CVMpuVjxrf6SSREGx9qwYxD+aSih44399vAaVMqYpZV+0JFKC8XbLRThY3s6KB3BUJ vNlI1g+qBYmp7QCxQr3hM9C+QGphMTFjYqPXL9hdn1K/Dm7HbJtcjexTUJlvX+ryo2+FFd Q4g+Pgi1iVC8E7kyIayaZ1D6/qM+pGDGrtHX/zJSyIJ/Mwm1PpwHuCUxmViZ50D2pmkQdm rBqMi+DHw92/ZFpLp7fLYrQdfBVFw31FbM/mSFFB5oLH12v3CVerlA6+ayss9w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757872055; a=rsa-sha256; cv=none; b=oJrHxOd13euFjjo4HYxb14A2nA9b+23bw56ps6QZuXA7FD6f2uvJGoOxGdmfZ6jZUxwN1C Qm1SUvKsvHL54VlEXxo72qwNYFLBXlvi23DnjqumBN/mRIvtj65vH8JNsOAbbIOxeNtggS xjQRkgedRd7odbiHVbE/Q7VuxYBQ5etDv8R+zKMs9TauGJh0/3iVHTPED2NN6JFk/rCkw1 DK/FM8r825RdfX2L+9r9mvyDdS8/pfKNYb5R3CEQM6jr7AQ40huCmNYLngS4g6Ysu2h3iF sddxsx8icSvNoe0C5Il/vqQ6H3DRGE2UUwlvovgkZgze0jPPbvwGJkRy9A36AQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cPwbp6F72z3dp; Sun, 14 Sep 2025 17:47:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58EHlYxo084770; Sun, 14 Sep 2025 17:47:34 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58EHlYEH084767; Sun, 14 Sep 2025 17:47:34 GMT (envelope-from git) Date: Sun, 14 Sep 2025 17:47:34 GMT Message-Id: <202509141747.58EHlYEH084767@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 52096ba6b769 - main - mpi3mr: Get rid of a supurious printf List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 52096ba6b7692ca204214959b8efffae87efa652 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=52096ba6b7692ca204214959b8efffae87efa652 commit 52096ba6b7692ca204214959b8efffae87efa652 Author: Warner Losh AuthorDate: 2025-09-14 17:29:40 +0000 Commit: Warner Losh CommitDate: 2025-09-14 17:29:40 +0000 mpi3mr: Get rid of a supurious printf If we have outstanding tractions and then poll and still have outstanding transactions, we print a warning. However, we print the warning, confusingly, even if there's 0 left. Enclose the two statements in {} to avoid this relatively harmless effect and quiet gcc12's indentation complaint. Sponsored by: Netflix --- sys/dev/mpi3mr/mpi3mr_cam.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/dev/mpi3mr/mpi3mr_cam.c b/sys/dev/mpi3mr/mpi3mr_cam.c index 77e25339a1a9..a5120e2788db 100644 --- a/sys/dev/mpi3mr/mpi3mr_cam.c +++ b/sys/dev/mpi3mr/mpi3mr_cam.c @@ -1856,10 +1856,11 @@ int mpi3mr_remove_device_from_os(struct mpi3mr_softc *sc, U16 handle) "Poll reply queue once\n", target_outstanding, target->per_id); mpi3mr_poll_pend_io_completions(sc); target_outstanding = mpi3mr_atomic_read(&target->outstanding); - if (target_outstanding) + if (target_outstanding) { target_outstanding = mpi3mr_atomic_read(&target->outstanding); mpi3mr_dprint(sc, MPI3MR_ERROR, "[%2d] outstanding IOs present on target: %d " - "despite poll\n", target_outstanding, target->per_id); + "despite poll\n", target_outstanding, target->per_id); + } } if (target->exposed_to_os && !sc->reset_in_progress) {