From owner-p4-projects@FreeBSD.ORG  Tue Jan 16 11:32:31 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A0F8216A415; Tue, 16 Jan 2007 11:32:31 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 578EE16A40F
	for <perforce@freebsd.org>; Tue, 16 Jan 2007 11:32:31 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 4786213C44B
	for <perforce@freebsd.org>; Tue, 16 Jan 2007 11:32:31 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l0GBWVsu095806
	for <perforce@freebsd.org>; Tue, 16 Jan 2007 11:32:31 GMT
	(envelope-from piso@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l0GBWUWr095801
	for perforce@freebsd.org; Tue, 16 Jan 2007 11:32:30 GMT
	(envelope-from piso@freebsd.org)
Date: Tue, 16 Jan 2007 11:32:30 GMT
Message-Id: <200701161132.l0GBWUWr095801@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	piso@freebsd.org using -f
From: Paolo Pisati <piso@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 112983 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jan 2007 11:32:31 -0000

http://perforce.freebsd.org/chv.cgi?CH=112983

Change 112983 by piso@piso_newluxor on 2007/01/16 11:31:42

	Get rid of the spin lock acquisition in the callout path.
	While here, do some spacing according to style.

Affected files ...

.. //depot/projects/soc2006/intr_filter/sparc64/sparc64/intr_machdep.c#20 edit

Differences ...

==== //depot/projects/soc2006/intr_filter/sparc64/sparc64/intr_machdep.c#20 (text+ko) ====

@@ -234,7 +234,7 @@
 {
 
 	mtx_init(&intr_table_lock, "intr table", NULL, MTX_SPIN);
-	callout_init_mtx(&stray_callout_handle, &intr_table_lock, 0);
+	callout_init(&stray_callout_handle, 1);
 }
 
 /* Stray detection MD code */
@@ -242,9 +242,10 @@
 walk_intr_sparc64(void) {
 	struct intr_vector *iv;
 	static int i = 0;
+	int j;
 
-	for (; i<IV_MAX; ) {
-		int j = i++;
+	for (; i<IV_MAX;) {
+		j = i++;
 		iv = &intr_vectors[j];
 		if (iv != NULL && iv->iv_event != NULL)
 			return (iv->iv_event);
@@ -257,10 +258,8 @@
 intr_callout_reset(void)
 {
 
-	mtx_lock_spin(&intr_table_lock);
 	callout_reset(&stray_callout_handle, hz, 
-		      &stray_detection, &walk_intr_sparc64);
-	mtx_unlock_spin(&intr_table_lock);
+	    &stray_detection, &walk_intr_sparc64);	
 }
 
 static void