From owner-p4-projects@FreeBSD.ORG Thu Jul 6 23:01:32 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id A5E6D16A609; Thu, 6 Jul 2006 23:01:32 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8082A16A5EC for ; Thu, 6 Jul 2006 23:01:32 +0000 (UTC) (envelope-from imp@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 51CB243D45 for ; Thu, 6 Jul 2006 23:01:32 +0000 (GMT) (envelope-from imp@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k66N1WIu056211 for ; Thu, 6 Jul 2006 23:01:32 GMT (envelope-from imp@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k66N1Vgf056208 for perforce@freebsd.org; Thu, 6 Jul 2006 23:01:31 GMT (envelope-from imp@freebsd.org) Date: Thu, 6 Jul 2006 23:01:31 GMT Message-Id: <200607062301.k66N1Vgf056208@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to imp@freebsd.org using -f From: Warner Losh To: Perforce Change Reviews Cc: Subject: PERFORCE change 100813 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2006 23:01:32 -0000 http://perforce.freebsd.org/chv.cgi?CH=100813 Change 100813 by imp@imp_lighthouse on 2006/07/06 23:00:51 Even when there's a timeout (especially?) you need to flush the cache properly. Why I didn't see this before now, I don't know. Affected files ... .. //depot/projects/arm/src/sys/arm/at91/uart_dev_at91usart.c#34 edit Differences ... ==== //depot/projects/arm/src/sys/arm/at91/uart_dev_at91usart.c#34 (text+ko) ==== @@ -568,6 +568,8 @@ // Not sure if there's a race here at fast baud rates // we need to worry about. WR4(&sc->sc_bas, PDC_PTCR, PDC_PTCR_RXTDIS); + bus_dmamap_sync(atsc->dmatag, atsc->ping->map, + BUS_DMASYNC_POSTREAD); len = sc->sc_rxfifosz - RD4(&sc->sc_bas, PDC_RCR); for (i = 0; i < len; i++) uart_rx_put(sc, atsc->ping->buffer[i]);